Promote Apps Developer Tools in the chrome:extensions page

chrome/browser/resources/extensions/extensions.js

Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 97bb296b225a3663fd703fa628829ed463b771ca..a4b8e0b7ec8ae4a994913cf99382731db18a8ef6 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -114,6 +114,15 @@ cr.define('extensions', function() {
       $('update-extensions-now').addEventListener('click',
           this.handleUpdateExtensionNow_.bind(this));
 
+      // Set up the close dialog for the apps developer tools promo.
+      this.promoDismissed_ = false;
+      $('apps-developer-tools-promo').querySelector('.close-button').
+          addEventListener('click', function(e) {
+        this.promoDismissed_ = true;
+        $('apps-developer-tools-promo').hidden = true;

[Dan Beam, 2014/04/18 22:34:23]

do we actually still need this ^ code?

[Devlin, 2014/04/18 22:54:38]

Whoops, gone.

+        $('extension-settings').classList.remove('adt-promo');

[Dan Beam, 2014/04/18 22:34:23]

using the helpful magic mentioned later:

  this.promoDismissed_ = true;
  this.updatePromoVisibility_();

[Devlin, 2014/04/18 22:54:38]

See below.

+      }.bind(this));
+
       if (!loadTimeData.getBoolean('offStoreInstallEnabled')) {
         this.dragWrapper_ = new cr.ui.DragWrapper(document.documentElement,
                                                   dragWrapperHandler);
@@ -297,6 +306,11 @@ cr.define('extensions', function() {
       $('toggle-dev-on').checked = false;
     }
 

[Dan Beam, 2014/04/18 22:34:23]

throw this somewhere

  /**
   * Updates (hides/shows) the promo based on whether it should be showing.
   * @private
   */
  updatePromoVisibility_: function() {
    var showPromo = extensionsData.promoteAppsDevTools && !this.promoDismissed_;
    $('extension-settings').classList.toggle('adt-promo', showPromo);
  },

and call from here

[Devlin, 2014/04/18 22:54:38]

extensionsData is a local variable. :(  We could make it this.extensionsData_,
but that seems a little much for the little it does... preference?  In the
meantime, updated the if / else to be the var showPromo + toggle, which makes it
a bit cleaner.

+    if (extensionsData.promoteAppsDevTools && !this.promoDismissed_)
+      pageDiv.classList.add('adt-promo');
+    else
+      pageDiv.classList.remove('adt-promo');
+
     $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;
 
     ExtensionsList.prototype.data_ = extensionsData;