Promote Apps Developer Tools in the chrome:extensions page

chrome/browser/resources/extensions/extensions.js

Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index 97bb296b225a3663fd703fa628829ed463b771ca..45620861910d51d5831f90faf0612178fc86dc48 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -114,6 +114,15 @@ cr.define('extensions', function() {
       $('update-extensions-now').addEventListener('click',
           this.handleUpdateExtensionNow_.bind(this));
 
+      // Set up the close dialog for the apps developer tools promo.
+      this.promoDismissed_ = false;
+      $('apps-developer-tools-promo').querySelector('.close-button')

[Dan Beam, 2014/04/18 21:27:28]

nit: . at end

[Devlin, 2014/04/18 22:19:55]

Whoops, sorry - git cl format is making bad habits for me ;)

+          .addEventListener('click', function(e) {
+        this.promoDismissed_ = true;
+        $('apps-developer-tools-promo').hidden = true;
+        $('extension-settings').classList.remove('adt-promo');
+      }.bind(this));
+
       if (!loadTimeData.getBoolean('offStoreInstallEnabled')) {
         this.dragWrapper_ = new cr.ui.DragWrapper(document.documentElement,
                                                   dragWrapperHandler);
@@ -297,6 +306,14 @@ cr.define('extensions', function() {
       $('toggle-dev-on').checked = false;
     }
 
+    if (extensionsData.promoteAppsDevTools && !this.promoDismissed_) {
+      $('apps-developer-tools-promo').hidden = false;
+      pageDiv.classList.add('adt-promo');

[Dan Beam, 2014/04/18 21:27:28]

why are we hiding the promo at all?  can't we just leave it unhidden but
obscured from view until .adt-promo is added/removed?

right now it seems like this would immediately hide the promo and transition its
parent's height after that... might look a bit jarring.

[Devlin, 2014/04/18 22:19:55]

Oh, I guess we can.  Nice.

+    } else {
+      $('apps-developer-tools-promo').hidden = true;
+      pageDiv.classList.remove('adt-promo');
+    }
+
     $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;
 
     ExtensionsList.prototype.data_ = extensionsData;