Promote Apps Developer Tools in the chrome:extensions page

chrome/browser/resources/extensions/extensions.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js"></include>
 <include src="extension_commands_overlay.js"></include>
 <include src="extension_focus_manager.js"></include>
 <include src="extension_list.js"></include>
 <include src="pack_extension_overlay.js"></include>
 <include src="extension_error_overlay.js"></include>
@@ skipping 96 matching lines @@
           this.handleDevControlsTransitionEnd_.bind(this));
 
       // Set up the three dev mode buttons (load unpacked, pack and update).
       $('load-unpacked').addEventListener('click',
           this.handleLoadUnpackedExtension_.bind(this));
       $('pack-extension').addEventListener('click',
           this.handlePackExtension_.bind(this));
       $('update-extensions-now').addEventListener('click',
           this.handleUpdateExtensionNow_.bind(this));
 
+      // Set up the close dialog for the apps developer tools promo.
+      this.promoDismissed_ = false;
+      $('apps-developer-tools-promo').querySelector('.close-button').
+          addEventListener('click', function(e) {
+        this.promoDismissed_ = true;
+        $('apps-developer-tools-promo').hidden = true;

[Dan Beam, 2014/04/18 22:34:23]

do we actually still need this ^ code?

[Devlin, 2014/04/18 22:54:38]

Whoops, gone.

+        $('extension-settings').classList.remove('adt-promo');

[Dan Beam, 2014/04/18 22:34:23]

using the helpful magic mentioned later:

  this.promoDismissed_ = true;
  this.updatePromoVisibility_();

[Devlin, 2014/04/18 22:54:38]

See below.

+      }.bind(this));
+
       if (!loadTimeData.getBoolean('offStoreInstallEnabled')) {
         this.dragWrapper_ = new cr.ui.DragWrapper(document.documentElement,
                                                   dragWrapperHandler);
       }
 
       extensions.PackExtensionOverlay.getInstance().initializePage();
 
       // Hook up the configure commands link to the overlay.
       var link = document.querySelector('.extension-commands-config');
       link.addEventListener('click',
@@ skipping 162 matching lines @@
     pageDiv.style.marginTop = marginTop + 'px';
 
     if (extensionsData.developerMode) {
       pageDiv.classList.add('dev-mode');
       $('toggle-dev-on').checked = true;
       $('dev-controls').hidden = false;
     } else {
       pageDiv.classList.remove('dev-mode');
       $('toggle-dev-on').checked = false;
     }
 

[Dan Beam, 2014/04/18 22:34:23]

throw this somewhere

  /**
   * Updates (hides/shows) the promo based on whether it should be showing.
   * @private
   */
  updatePromoVisibility_: function() {
    var showPromo = extensionsData.promoteAppsDevTools && !this.promoDismissed_;
    $('extension-settings').classList.toggle('adt-promo', showPromo);
  },

and call from here

[Devlin, 2014/04/18 22:54:38]

extensionsData is a local variable. :(  We could make it this.extensionsData_,
but that seems a little much for the little it does... preference?  In the
meantime, updated the if / else to be the var showPromo + toggle, which makes it
a bit cleaner.

+    if (extensionsData.promoteAppsDevTools && !this.promoDismissed_)
+      pageDiv.classList.add('adt-promo');
+    else
+      pageDiv.classList.remove('adt-promo');
+
     $('load-unpacked').disabled = extensionsData.loadUnpackedDisabled;
 
     ExtensionsList.prototype.data_ = extensionsData;
     var extensionList = $('extension-settings-list');
     ExtensionsList.decorate(extensionList);
   }
 
   // Indicate that warning |message| has occured for pack of |crx_path| and
   // |pem_path| files.  Ask if user wants override the warning.  Send
   // |overrideFlags| to repeated 'pack' call to accomplish the override.
@@ skipping 89 matching lines @@
 
   // Export
   return {
     ExtensionSettings: ExtensionSettings
   };
 });
 
 window.addEventListener('load', function(e) {
   extensions.ExtensionSettings.getInstance().initialize();
 });