Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 196413028: Promote Apps Developer Tools in the chrome:extensions page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/app_restore_service.h" 8 #include "apps/app_restore_service.h"
9 #include "apps/app_window.h" 9 #include "apps/app_window.h"
10 #include "apps/app_window_registry.h" 10 #include "apps/app_window_registry.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 #include "chrome/browser/managed_mode/managed_user_service.h" 45 #include "chrome/browser/managed_mode/managed_user_service.h"
46 #include "chrome/browser/managed_mode/managed_user_service_factory.h" 46 #include "chrome/browser/managed_mode/managed_user_service_factory.h"
47 #include "chrome/browser/profiles/profile.h" 47 #include "chrome/browser/profiles/profile.h"
48 #include "chrome/browser/tab_contents/background_contents.h" 48 #include "chrome/browser/tab_contents/background_contents.h"
49 #include "chrome/browser/ui/browser_finder.h" 49 #include "chrome/browser/ui/browser_finder.h"
50 #include "chrome/browser/ui/chrome_select_file_policy.h" 50 #include "chrome/browser/ui/chrome_select_file_policy.h"
51 #include "chrome/browser/ui/extensions/application_launch.h" 51 #include "chrome/browser/ui/extensions/application_launch.h"
52 #include "chrome/browser/ui/webui/extensions/extension_basic_info.h" 52 #include "chrome/browser/ui/webui/extensions/extension_basic_info.h"
53 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h" 53 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
54 #include "chrome/common/chrome_switches.h" 54 #include "chrome/common/chrome_switches.h"
55 #include "chrome/common/chrome_version_info.h"
55 #include "chrome/common/extensions/extension_constants.h" 56 #include "chrome/common/extensions/extension_constants.h"
57 #include "chrome/common/extensions/features/feature_channel.h"
56 #include "chrome/common/extensions/manifest_url_handler.h" 58 #include "chrome/common/extensions/manifest_url_handler.h"
57 #include "chrome/common/pref_names.h" 59 #include "chrome/common/pref_names.h"
58 #include "chrome/common/url_constants.h" 60 #include "chrome/common/url_constants.h"
59 #include "components/user_prefs/pref_registry_syncable.h" 61 #include "components/user_prefs/pref_registry_syncable.h"
60 #include "content/public/browser/notification_service.h" 62 #include "content/public/browser/notification_service.h"
61 #include "content/public/browser/notification_source.h" 63 #include "content/public/browser/notification_source.h"
62 #include "content/public/browser/notification_types.h" 64 #include "content/public/browser/notification_types.h"
63 #include "content/public/browser/render_process_host.h" 65 #include "content/public/browser/render_process_host.h"
64 #include "content/public/browser/render_view_host.h" 66 #include "content/public/browser/render_view_host.h"
65 #include "content/public/browser/site_instance.h" 67 #include "content/public/browser/site_instance.h"
66 #include "content/public/browser/user_metrics.h" 68 #include "content/public/browser/user_metrics.h"
67 #include "content/public/browser/web_contents.h" 69 #include "content/public/browser/web_contents.h"
68 #include "content/public/browser/web_contents_view.h" 70 #include "content/public/browser/web_contents_view.h"
69 #include "content/public/browser/web_ui.h" 71 #include "content/public/browser/web_ui.h"
70 #include "content/public/browser/web_ui_data_source.h" 72 #include "content/public/browser/web_ui_data_source.h"
71 #include "extensions/browser/blacklist_state.h" 73 #include "extensions/browser/blacklist_state.h"
72 #include "extensions/browser/extension_error.h" 74 #include "extensions/browser/extension_error.h"
73 #include "extensions/browser/extension_host.h" 75 #include "extensions/browser/extension_host.h"
74 #include "extensions/browser/extension_registry.h" 76 #include "extensions/browser/extension_registry.h"
75 #include "extensions/browser/extension_system.h" 77 #include "extensions/browser/extension_system.h"
76 #include "extensions/browser/lazy_background_task_queue.h" 78 #include "extensions/browser/lazy_background_task_queue.h"
77 #include "extensions/browser/management_policy.h" 79 #include "extensions/browser/management_policy.h"
78 #include "extensions/browser/pref_names.h" 80 #include "extensions/browser/pref_names.h"
79 #include "extensions/browser/view_type_utils.h" 81 #include "extensions/browser/view_type_utils.h"
80 #include "extensions/common/constants.h" 82 #include "extensions/common/constants.h"
81 #include "extensions/common/extension.h" 83 #include "extensions/common/extension.h"
82 #include "extensions/common/extension_icon_set.h" 84 #include "extensions/common/extension_icon_set.h"
83 #include "extensions/common/extension_set.h" 85 #include "extensions/common/extension_set.h"
84 #include "extensions/common/feature_switch.h"
85 #include "extensions/common/manifest.h" 86 #include "extensions/common/manifest.h"
86 #include "extensions/common/manifest_handlers/background_info.h" 87 #include "extensions/common/manifest_handlers/background_info.h"
87 #include "extensions/common/manifest_handlers/incognito_info.h" 88 #include "extensions/common/manifest_handlers/incognito_info.h"
88 #include "grit/browser_resources.h" 89 #include "grit/browser_resources.h"
89 #include "grit/chromium_strings.h" 90 #include "grit/chromium_strings.h"
90 #include "grit/generated_resources.h" 91 #include "grit/generated_resources.h"
91 #include "grit/theme_resources.h" 92 #include "grit/theme_resources.h"
92 #include "ui/base/l10n/l10n_util.h" 93 #include "ui/base/l10n/l10n_util.h"
93 #include "ui/base/resource/resource_bundle.h" 94 #include "ui/base/resource/resource_bundle.h"
94 95
95 using base::DictionaryValue; 96 using base::DictionaryValue;
96 using base::ListValue; 97 using base::ListValue;
97 using content::RenderViewHost; 98 using content::RenderViewHost;
98 using content::WebContents; 99 using content::WebContents;
99 100
101 namespace {
102 const char kAppsDeveloperToolsExtensionId[] =
103 "ohmmkhmmmpcnpikjeljgnaoabkaalbgc";
104 }
105
100 namespace extensions { 106 namespace extensions {
101 107
102 ExtensionPage::ExtensionPage(const GURL& url, 108 ExtensionPage::ExtensionPage(const GURL& url,
103 int render_process_id, 109 int render_process_id,
104 int render_view_id, 110 int render_view_id,
105 bool incognito, 111 bool incognito,
106 bool generated_background_page) 112 bool generated_background_page)
107 : url(url), 113 : url(url),
108 render_process_id(render_process_id), 114 render_process_id(render_process_id),
109 render_view_id(render_view_id), 115 render_view_id(render_view_id),
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 source->AddString("extensionSettingsShowButton", 473 source->AddString("extensionSettingsShowButton",
468 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_BUTTON)); 474 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_BUTTON));
469 source->AddString("extensionSettingsLoadUnpackedButton", 475 source->AddString("extensionSettingsLoadUnpackedButton",
470 l10n_util::GetStringUTF16(IDS_EXTENSIONS_LOAD_UNPACKED_BUTTON)); 476 l10n_util::GetStringUTF16(IDS_EXTENSIONS_LOAD_UNPACKED_BUTTON));
471 source->AddString("extensionSettingsPackButton", 477 source->AddString("extensionSettingsPackButton",
472 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON)); 478 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON));
473 source->AddString("extensionSettingsCommandsLink", 479 source->AddString("extensionSettingsCommandsLink",
474 l10n_util::GetStringUTF16(IDS_EXTENSIONS_COMMANDS_CONFIGURE)); 480 l10n_util::GetStringUTF16(IDS_EXTENSIONS_COMMANDS_CONFIGURE));
475 source->AddString("extensionSettingsUpdateButton", 481 source->AddString("extensionSettingsUpdateButton",
476 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON)); 482 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON));
483 source->AddString(
484 "extensionSettingsAppsDevToolsPromoText",
485 l10n_util::GetStringUTF16(IDS_EXTENSIONS_APPS_DEV_TOOLS_PROMO_TEXT));
486 source->AddString(
487 "extensionSettingsAppsDevToolsLinkText",
488 l10n_util::GetStringUTF16(IDS_EXTENSIONS_APPS_DEV_TOOLS_LINK_TEXT));
489 source->AddString(
490 "extensionSettingsAppsDevToolsUrl",
491 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
492 GURL(extension_urls::GetWebstoreItemDetailURLPrefix() +
493 kAppsDeveloperToolsExtensionId)).spec()));
477 source->AddString("extensionSettingsCrashMessage", 494 source->AddString("extensionSettingsCrashMessage",
478 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION)); 495 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION));
479 source->AddString("extensionSettingsInDevelopment", 496 source->AddString("extensionSettingsInDevelopment",
480 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT)); 497 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT));
481 source->AddString("extensionSettingsWarningsTitle", 498 source->AddString("extensionSettingsWarningsTitle",
482 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE)); 499 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE));
483 source->AddString("extensionSettingsShowDetails", 500 source->AddString("extensionSettingsShowDetails",
484 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS)); 501 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_DETAILS));
485 source->AddString("extensionSettingsHideDetails", 502 source->AddString("extensionSettingsHideDetails",
486 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS)); 503 l10n_util::GetStringUTF16(IDS_EXTENSIONS_HIDE_DETAILS));
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
817 } 834 }
818 results.Set("extensions", extensions_list); 835 results.Set("extensions", extensions_list);
819 836
820 bool is_managed = profile->IsManaged(); 837 bool is_managed = profile->IsManaged();
821 bool developer_mode = 838 bool developer_mode =
822 !is_managed && 839 !is_managed &&
823 profile->GetPrefs()->GetBoolean(prefs::kExtensionsUIDeveloperMode); 840 profile->GetPrefs()->GetBoolean(prefs::kExtensionsUIDeveloperMode);
824 results.SetBoolean("profileIsManaged", is_managed); 841 results.SetBoolean("profileIsManaged", is_managed);
825 results.SetBoolean("developerMode", developer_mode); 842 results.SetBoolean("developerMode", developer_mode);
826 843
844 // Promote the Apps Developer Tools if they're not installed.
845 bool promote_apps_dev_tools =
846 GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV &&
847 !ExtensionRegistry::Get(Profile::FromWebUI(web_ui()))->
848 GetExtensionById(kAppsDeveloperToolsExtensionId,
849 ExtensionRegistry::EVERYTHING);
850 results.SetBoolean("promoteAppsDevTools", promote_apps_dev_tools);
851
827 bool load_unpacked_disabled = 852 bool load_unpacked_disabled =
828 ExtensionPrefs::Get(profile)->ExtensionsBlacklistedByDefault(); 853 ExtensionPrefs::Get(profile)->ExtensionsBlacklistedByDefault();
829 results.SetBoolean("loadUnpackedDisabled", load_unpacked_disabled); 854 results.SetBoolean("loadUnpackedDisabled", load_unpacked_disabled);
830 855
831 web_ui()->CallJavascriptFunction( 856 web_ui()->CallJavascriptFunction(
832 "extensions.ExtensionSettings.returnExtensionsData", results); 857 "extensions.ExtensionSettings.returnExtensionsData", results);
833 858
834 MaybeRegisterForNotifications(); 859 MaybeRegisterForNotifications();
835 UMA_HISTOGRAM_BOOLEAN("ExtensionSettings.ShouldDoVerificationCheck", 860 UMA_HISTOGRAM_BOOLEAN("ExtensionSettings.ShouldDoVerificationCheck",
836 should_do_verification_check_); 861 should_do_verification_check_);
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
1353 const base::FilePath& path) { 1378 const base::FilePath& path) {
1354 if (IndexOfLoadingPath(path) == -1) 1379 if (IndexOfLoadingPath(path) == -1)
1355 return; // Not an extension we're tracking. 1380 return; // Not an extension we're tracking.
1356 if (retry) 1381 if (retry)
1357 LoadUnpackedExtension(path); 1382 LoadUnpackedExtension(path);
1358 else 1383 else
1359 RemoveLoadingPath(path); 1384 RemoveLoadingPath(path);
1360 } 1385 }
1361 1386
1362 } // namespace extensions 1387 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/resources/extensions/extensions.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698