Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/win.py

Issue 196413027: Point to build requirements page when there is a dependency check failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/mac.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 port_name = 'win' 51 port_name = 'win'
52 52
53 # FIXME: Figure out how to unify this with base.TestConfiguration.all_system s()? 53 # FIXME: Figure out how to unify this with base.TestConfiguration.all_system s()?
54 SUPPORTED_VERSIONS = ('xp', 'win7') 54 SUPPORTED_VERSIONS = ('xp', 'win7')
55 55
56 FALLBACK_PATHS = { 'win7': [ 'win' ]} 56 FALLBACK_PATHS = { 'win7': [ 'win' ]}
57 FALLBACK_PATHS['xp'] = ['win-xp'] + FALLBACK_PATHS['win7'] 57 FALLBACK_PATHS['xp'] = ['win-xp'] + FALLBACK_PATHS['win7']
58 58
59 DEFAULT_BUILD_DIRECTORIES = ('build', 'out') 59 DEFAULT_BUILD_DIRECTORIES = ('build', 'out')
60 60
61 BUILD_REQUIREMENTS_URL = 'http://www.chromium.org/developers/how-tos/build-i nstructions-windows'
62
61 @classmethod 63 @classmethod
62 def determine_full_port_name(cls, host, options, port_name): 64 def determine_full_port_name(cls, host, options, port_name):
63 if port_name.endswith('win'): 65 if port_name.endswith('win'):
64 assert host.platform.is_win() 66 assert host.platform.is_win()
65 # We don't maintain separate baselines for vista, so we pretend it i s win7. 67 # We don't maintain separate baselines for vista, so we pretend it i s win7.
66 if host.platform.os_version in ('vista', '7sp0', '7sp1', 'future'): 68 if host.platform.os_version in ('vista', '7sp0', '7sp1', 'future'):
67 version = 'win7' 69 version = 'win7'
68 else: 70 else:
69 version = host.platform.os_version 71 version = host.platform.os_version
70 port_name = port_name + '-' + version 72 port_name = port_name + '-' + version
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 return result 255 return result
254 256
255 def look_for_new_crash_logs(self, crashed_processes, start_time): 257 def look_for_new_crash_logs(self, crashed_processes, start_time):
256 if self.get_option('disable_breakpad'): 258 if self.get_option('disable_breakpad'):
257 return None 259 return None
258 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time) 260 return self._dump_reader.look_for_new_crash_logs(crashed_processes, star t_time)
259 261
260 def clobber_old_port_specific_results(self): 262 def clobber_old_port_specific_results(self):
261 if not self.get_option('disable_breakpad'): 263 if not self.get_option('disable_breakpad'):
262 self._dump_reader.clobber_old_results() 264 self._dump_reader.clobber_old_results()
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/mac.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698