Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 196413027: Point to build requirements page when there is a dependency check failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 'android': ['icecreamsandwich'], 123 'android': ['icecreamsandwich'],
124 } 124 }
125 125
126 DEFAULT_BUILD_DIRECTORIES = ('out',) 126 DEFAULT_BUILD_DIRECTORIES = ('out',)
127 127
128 # overridden in subclasses. 128 # overridden in subclasses.
129 FALLBACK_PATHS = {} 129 FALLBACK_PATHS = {}
130 130
131 SUPPORTED_VERSIONS = [] 131 SUPPORTED_VERSIONS = []
132 132
133 # URL to the build requirements page.
134 BUILD_REQUIREMENTS_URL = ''
135
133 @classmethod 136 @classmethod
134 def latest_platform_fallback_path(cls): 137 def latest_platform_fallback_path(cls):
135 return cls.FALLBACK_PATHS[cls.SUPPORTED_VERSIONS[-1]] 138 return cls.FALLBACK_PATHS[cls.SUPPORTED_VERSIONS[-1]]
136 139
137 @classmethod 140 @classmethod
138 def _static_build_path(cls, filesystem, build_directory, chromium_base, conf iguration, comps): 141 def _static_build_path(cls, filesystem, build_directory, chromium_base, conf iguration, comps):
139 if build_directory: 142 if build_directory:
140 return filesystem.join(build_directory, configuration, *comps) 143 return filesystem.join(build_directory, configuration, *comps)
141 144
142 hits = [] 145 hits = []
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
376 379
377 def error_handler(script_error): 380 def error_handler(script_error):
378 local_error.exit_code = script_error.exit_code 381 local_error.exit_code = script_error.exit_code
379 382
380 output = self._executive.run_command(cmd, error_handler=error_handler) 383 output = self._executive.run_command(cmd, error_handler=error_handler)
381 if local_error.exit_code: 384 if local_error.exit_code:
382 _log.error('System dependencies check failed.') 385 _log.error('System dependencies check failed.')
383 _log.error('To override, invoke with --nocheck-sys-deps') 386 _log.error('To override, invoke with --nocheck-sys-deps')
384 _log.error('') 387 _log.error('')
385 _log.error(output) 388 _log.error(output)
389 if self.BUILD_REQUIREMENTS_URL is not '':
390 _log.error('')
391 _log.error('For complete build requirements, please see:')
392 _log.error(self.BUILD_REQUIREMENTS_URL)
386 return test_run_results.SYS_DEPS_EXIT_STATUS 393 return test_run_results.SYS_DEPS_EXIT_STATUS
387 return test_run_results.OK_EXIT_STATUS 394 return test_run_results.OK_EXIT_STATUS
388 395
389 def check_image_diff(self, override_step=None, logging=True): 396 def check_image_diff(self, override_step=None, logging=True):
390 """This routine is used to check whether image_diff binary exists.""" 397 """This routine is used to check whether image_diff binary exists."""
391 image_diff_path = self._path_to_image_diff() 398 image_diff_path = self._path_to_image_diff()
392 if not self._filesystem.exists(image_diff_path): 399 if not self._filesystem.exists(image_diff_path):
393 _log.error("image_diff was not found at %s" % image_diff_path) 400 _log.error("image_diff was not found at %s" % image_diff_path)
394 return False 401 return False
395 return True 402 return True
(...skipping 1350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1746 if name.find('/') != -1: 1753 if name.find('/') != -1:
1747 _log.error("Virtual test suites names cannot contain /'s: %s" % name) 1754 _log.error("Virtual test suites names cannot contain /'s: %s" % name)
1748 return 1755 return
1749 self.name = 'virtual/' + name + '/' + base 1756 self.name = 'virtual/' + name + '/' + base
1750 self.base = base 1757 self.base = base
1751 self.args = args 1758 self.args = args
1752 self.tests = tests or set() 1759 self.tests = tests or set()
1753 1760
1754 def __repr__(self): 1761 def __repr__(self):
1755 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args) 1762 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args)
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/android.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698