Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright (C) 2010 Google Inc. All rights reserved. | 1 # Copyright (C) 2010 Google Inc. All rights reserved. |
| 2 # | 2 # |
| 3 # Redistribution and use in source and binary forms, with or without | 3 # Redistribution and use in source and binary forms, with or without |
| 4 # modification, are permitted provided that the following conditions are | 4 # modification, are permitted provided that the following conditions are |
| 5 # met: | 5 # met: |
| 6 # | 6 # |
| 7 # * Redistributions of source code must retain the above copyright | 7 # * Redistributions of source code must retain the above copyright |
| 8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
| 9 # * Redistributions in binary form must reproduce the above | 9 # * Redistributions in binary form must reproduce the above |
| 10 # copyright notice, this list of conditions and the following disclaimer | 10 # copyright notice, this list of conditions and the following disclaimer |
| (...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 376 | 376 |
| 377 def error_handler(script_error): | 377 def error_handler(script_error): |
| 378 local_error.exit_code = script_error.exit_code | 378 local_error.exit_code = script_error.exit_code |
| 379 | 379 |
| 380 output = self._executive.run_command(cmd, error_handler=error_handler) | 380 output = self._executive.run_command(cmd, error_handler=error_handler) |
| 381 if local_error.exit_code: | 381 if local_error.exit_code: |
| 382 _log.error('System dependencies check failed.') | 382 _log.error('System dependencies check failed.') |
| 383 _log.error('To override, invoke with --nocheck-sys-deps') | 383 _log.error('To override, invoke with --nocheck-sys-deps') |
| 384 _log.error('') | 384 _log.error('') |
| 385 _log.error(output) | 385 _log.error(output) |
| 386 if sys.platform.startswith('linux'): | |
|
Peter Beverloo
2014/03/20 15:09:12
self.host.platform.is_linux()
mlamouri (slow - plz ping)
2014/03/20 17:21:01
Done.
| |
| 387 _log.error('') | |
| 388 _log.error('Did you install the dependencies listed here?') | |
|
Peter Beverloo
2014/03/20 15:09:12
Please phrase this as a statement instead. To be c
mlamouri (slow - plz ping)
2014/03/20 17:21:01
Done.
| |
| 389 _log.error('https://code.google.com/p/chromium/wiki/LayoutTestsL inux') | |
| 386 return test_run_results.SYS_DEPS_EXIT_STATUS | 390 return test_run_results.SYS_DEPS_EXIT_STATUS |
| 387 return test_run_results.OK_EXIT_STATUS | 391 return test_run_results.OK_EXIT_STATUS |
| 388 | 392 |
| 389 def check_image_diff(self, override_step=None, logging=True): | 393 def check_image_diff(self, override_step=None, logging=True): |
| 390 """This routine is used to check whether image_diff binary exists.""" | 394 """This routine is used to check whether image_diff binary exists.""" |
| 391 image_diff_path = self._path_to_image_diff() | 395 image_diff_path = self._path_to_image_diff() |
| 392 if not self._filesystem.exists(image_diff_path): | 396 if not self._filesystem.exists(image_diff_path): |
| 393 _log.error("image_diff was not found at %s" % image_diff_path) | 397 _log.error("image_diff was not found at %s" % image_diff_path) |
| 394 return False | 398 return False |
| 395 return True | 399 return True |
| (...skipping 1350 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1746 if name.find('/') != -1: | 1750 if name.find('/') != -1: |
| 1747 _log.error("Virtual test suites names cannot contain /'s: %s" % name) | 1751 _log.error("Virtual test suites names cannot contain /'s: %s" % name) |
| 1748 return | 1752 return |
| 1749 self.name = 'virtual/' + name + '/' + base | 1753 self.name = 'virtual/' + name + '/' + base |
| 1750 self.base = base | 1754 self.base = base |
| 1751 self.args = args | 1755 self.args = args |
| 1752 self.tests = tests or set() | 1756 self.tests = tests or set() |
| 1753 | 1757 |
| 1754 def __repr__(self): | 1758 def __repr__(self): |
| 1755 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args) | 1759 return "VirtualTestSuite('%s', '%s', %s)" % (self.name, self.base, self. args) |
| OLD | NEW |