Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: Source/core/rendering/RenderTableCol.h

Issue 196413002: Don't allow position:sticky for table columns. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTableCol.h
diff --git a/Source/core/rendering/RenderTableCol.h b/Source/core/rendering/RenderTableCol.h
index f3ccef57aa1181b5e7a8465f2c8d672b81f0612e..c5c2882c635d23d2ff0c9a123112b8484b896375 100644
--- a/Source/core/rendering/RenderTableCol.h
+++ b/Source/core/rendering/RenderTableCol.h
@@ -90,7 +90,13 @@ private:
virtual bool isChildAllowed(RenderObject*, RenderStyle*) const OVERRIDE;
virtual bool canHaveChildren() const OVERRIDE;
- virtual LayerType layerTypeRequired() const OVERRIDE { return NoLayer; }
+ virtual LayerType layerTypeRequired() const OVERRIDE
+ {
+ if (isStickyPositioned())
Julien - ping for review 2014/03/12 03:14:42 columns are only style placeholder. That's the rea
ostap 2014/03/12 05:26:24 I think that table column can be sticky positioned
Julien - ping for review 2014/03/12 15:17:04 Yes, it can but that doesn't mean that we should a
ostap 2014/03/12 15:51:12 Ok. I'll disable sticky support for table elements
+ return NormalLayer;
+
+ return NoLayer;
+ }
virtual LayoutRect clippedOverflowRectForRepaint(const RenderLayerModelObject* repaintContainer) const OVERRIDE;
virtual void imageChanged(WrappedImagePtr, const IntRect* = 0) OVERRIDE;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698