Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964123002: Finishing: https://codereview.chromium.org/1948763003 (Closed)

Created:
4 years, 7 months ago by jlebel
Modified:
4 years, 7 months ago
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finishing: https://codereview.chromium.org/1948763003 Removing all services all at once. BUG=603183 Committed: https://crrev.com/abd908b0563133154ba42f77f26349b6be20b9b2 Cr-Commit-Position: refs/heads/master@{#392731}

Patch Set 1 #

Patch Set 2 : Better #

Total comments: 1

Patch Set 3 : Updating comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 1 2 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jlebel
Hello Giovanni, Sorry about forgetting your comments on the previous patch.
4 years, 7 months ago (2016-05-10 19:38:23 UTC) #2
ortuno
https://codereview.chromium.org/1964123002/diff/20001/device/bluetooth/bluetooth_low_energy_device_mac.mm File device/bluetooth/bluetooth_low_energy_device_mac.mm (right): https://codereview.chromium.org/1964123002/diff/20001/device/bluetooth/bluetooth_low_energy_device_mac.mm#newcode325 device/bluetooth/bluetooth_low_energy_device_mac.mm:325: // Removing all services at once. nit: Keep the ...
4 years, 7 months ago (2016-05-10 19:40:14 UTC) #3
jlebel
The comment has been updated.
4 years, 7 months ago (2016-05-10 20:18:50 UTC) #4
ortuno
lgtm
4 years, 7 months ago (2016-05-10 20:22:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964123002/40001
4 years, 7 months ago (2016-05-10 20:28:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 21:40:44 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 21:42:23 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/abd908b0563133154ba42f77f26349b6be20b9b2
Cr-Commit-Position: refs/heads/master@{#392731}

Powered by Google App Engine
This is Rietveld 408576698