Issue 19641008: Implement ChildThread::shutdown and clear members that have refs into blink

Issue 19641008: Implement ChildThread::shutdown and clear members that have refs into blink (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 5 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement ChildThread::shutdown and clear members that have refs into blink This enables classes deriving frmo ChildThread to cleanly shut down WebKit BUG=263034 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213239

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
M	content/child/child_thread.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/child_thread.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/gpu/gpu_child_thread.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/plugin/plugin_thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/utility/utility_thread_impl.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/worker/worker_thread.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/19641008/diff/1/content/child/child_thread.cc File content/child/child_thread.cc (right): https://codereview.chromium.org/19641008/diff/1/content/child/child_thread.cc#newcode285 content/child/child_thread.cc:285: if (file_system_dispatcher_ && are you sure this can ...

7 years, 5 months ago (2013-07-23 16:44:22 UTC) #2

jochen (gone - plz use gerrit)

On 2013/07/23 16:44:22, jam wrote: > lgtm > > https://codereview.chromium.org/19641008/diff/1/content/child/child_thread.cc > File content/child/child_thread.cc (right): > ...

7 years, 5 months ago (2013-07-23 18:48:15 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/19641008/10001

7 years, 5 months ago (2013-07-23 18:49:19 UTC) #4

Message was sent while issue was closed.

Change committed as 213239

Expand Messages | Collapse Messages