Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1964083002: Move invalidateDisplayItemClients() override into LayoutBlockFlow and eat the static helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
index bc46a2b38b836012f8081342507ed02f5b264f16..92ab89daac17eaa2feafd79caf3f0c997a1f4b04 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
@@ -377,33 +377,6 @@ bool LayoutBlock::allowsOverflowClip() const
return node() != document().viewportDefiningElement();
}
-inline static void invalidateDisplayItemClientForStartOfContinuationsIfNeeded(const LayoutBlock& block)
-{
- // If the block is a continuation or containing block of an inline continuation, invalidate the
- // start object of the continuations if it has focus ring because change of continuation may change
- // the shape of the focus ring.
- if (!block.isAnonymous())
- return;
-
- LayoutObject* startOfContinuations = nullptr;
- if (LayoutInline* inlineElementContinuation = block.inlineElementContinuation()) {
- // This block is an anonymous block continuation.
- startOfContinuations = inlineElementContinuation->node()->layoutObject();
- } else if (LayoutObject* firstChild = block.firstChild()) {
- // This block is the anonymous containing block of an inline element continuation.
- if (firstChild->isElementContinuation())
- startOfContinuations = firstChild->node()->layoutObject();
- }
- if (startOfContinuations && startOfContinuations->styleRef().outlineStyleIsAuto())
- startOfContinuations->invalidateDisplayItemClient(*startOfContinuations);
-}
-
-void LayoutBlock::invalidateDisplayItemClients(const LayoutBoxModelObject& paintInvalidationContainer, PaintInvalidationReason invalidationReason) const
-{
- LayoutBox::invalidateDisplayItemClients(paintInvalidationContainer, invalidationReason);
- invalidateDisplayItemClientForStartOfContinuationsIfNeeded(*this);
-}
-
void LayoutBlock::addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* beforeChild)
{
if (beforeChild && beforeChild->parent() != this) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.h ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698