Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1964083002: Move invalidateDisplayItemClients() override into LayoutBlockFlow and eat the static helper. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
szager1, wkorman, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move invalidateDisplayItemClients() override into LayoutBlockFlow and eat the static helper. It was only dealing with continuations, and that doesn't belong in LayoutBlock. BUG=302024 Committed: https://crrev.com/c62d9e7e15d821ea3b245cccfe05a0d6e4458ecf Cr-Commit-Position: refs/heads/master@{#392690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -29 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-10 18:26:25 UTC) #2
eae
LGTM Mmmm, delicious static helpers!
4 years, 7 months ago (2016-05-10 18:28:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964083002/1
4 years, 7 months ago (2016-05-10 18:29:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 19:53:37 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:55:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c62d9e7e15d821ea3b245cccfe05a0d6e4458ecf
Cr-Commit-Position: refs/heads/master@{#392690}

Powered by Google App Engine
This is Rietveld 408576698