Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1964053002: Remove config range asserts that cause tautological-constant-out-of-range-compare warnings (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove config range asserts that cause tautological-constant-out-of-range-compare warnings on clang GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1964053002 Committed: https://skia.googlesource.com/skia/+/1e42775df95a6d55634c18a048dbee4379e1f688

Patch Set 1 #

Patch Set 2 : revert accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/gpu/vk/GrVkCaps.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bsalomon
I'm not sure these asserts add much value and they are causing errors on the ...
4 years, 7 months ago (2016-05-10 16:55:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964053002/20001
4 years, 7 months ago (2016-05-10 16:55:35 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 7 months ago (2016-05-10 16:55:36 UTC) #6
jvanverth1
lgtm
4 years, 7 months ago (2016-05-10 17:22:06 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:23:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1e42775df95a6d55634c18a048dbee4379e1f688

Powered by Google App Engine
This is Rietveld 408576698