Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 196403008: gl: Move platform-specific EGL code into separate files (Closed)

Created:
6 years, 9 months ago by spang
Modified:
6 years, 9 months ago
Reviewers:
rjkroege, piman
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

gl: Move platform-specific EGL code into separate files This splits ozone & android GLSurface creation into their own files, matching all of the other platforms. Also, all platforms that support EGL now implement GetPlatformDefaultEGLNativeDisplay() to determine the EGL display to use, eliminating an ifdef. This is cleaning things up in preparation for introducing a new ozone-specific GLSurfaceEGL subclass without adding more ifdefs. TEST=ui_unittests, content_shell --ozone-platform={file,dri} BUG=353788 R=piman@chromium.org, rjkroege@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259923

Patch Set 1 #

Total comments: 6

Patch Set 2 : introduce GetPlatformDefaultEGLNativeDisplay #

Patch Set 3 : rebase #

Patch Set 4 : fix windows build #

Patch Set 5 : rebase #

Patch Set 6 : rebase again, ARGH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -136 lines) Patch
M ui/gl/gl.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
A ui/gl/gl_surface_android.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 2 3 5 6 chunks +7 lines, -136 lines 0 comments Download
M ui/gl/gl_surface_osmesa.h View 1 chunk +17 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_osmesa.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A ui/gl/gl_surface_ozone.cc View 1 1 chunk +94 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_win.cc View 1 2 3 5 3 chunks +14 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_x11.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (0 generated)
spang
6 years, 9 months ago (2014-03-20 17:20:30 UTC) #1
spang
This depends on https://codereview.chromium.org/202683003/
6 years, 9 months ago (2014-03-20 17:23:02 UTC) #2
rjkroege
https://codereview.chromium.org/196403008/diff/1/ui/gl/gl_surface_android.cc File ui/gl/gl_surface_android.cc (right): https://codereview.chromium.org/196403008/diff/1/ui/gl/gl_surface_android.cc#newcode71 ui/gl/gl_surface_android.cc:71: } else can you put the { in please. ...
6 years, 9 months ago (2014-03-24 15:27:25 UTC) #3
spang
https://codereview.chromium.org/196403008/diff/1/ui/gl/gl_surface_android.cc File ui/gl/gl_surface_android.cc (right): https://codereview.chromium.org/196403008/diff/1/ui/gl/gl_surface_android.cc#newcode71 ui/gl/gl_surface_android.cc:71: } else On 2014/03/24 15:27:25, rjkroege wrote: > can ...
6 years, 9 months ago (2014-03-24 18:17:08 UTC) #4
spang
6 years, 9 months ago (2014-03-24 18:17:08 UTC) #5
rjkroege
lgtm with nits: I think that you need to update the CL description appropriately for ...
6 years, 9 months ago (2014-03-24 20:06:23 UTC) #6
spang
+piman
6 years, 9 months ago (2014-03-26 16:45:43 UTC) #7
piman
lgtm
6 years, 9 months ago (2014-03-26 18:09:11 UTC) #8
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-26 18:41:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/170001
6 years, 9 months ago (2014-03-26 18:42:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 23:55:31 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=288702
6 years, 9 months ago (2014-03-26 23:55:31 UTC) #12
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 15:29:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/170001
6 years, 9 months ago (2014-03-27 15:30:21 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:31:23 UTC) #15
commit-bot: I haz the power
Failed to apply patch for ui/gl/gl_surface_egl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-27 15:31:26 UTC) #16
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 15:43:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/190001
6 years, 9 months ago (2014-03-27 15:43:48 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 15:53:59 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 9 months ago (2014-03-27 15:53:59 UTC) #20
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 15:55:25 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/190001
6 years, 9 months ago (2014-03-27 15:55:32 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:11:09 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-27 16:11:10 UTC) #24
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 16:24:55 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/190001
6 years, 9 months ago (2014-03-27 16:25:29 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 16:31:36 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 9 months ago (2014-03-27 16:31:36 UTC) #28
spang
The CQ bit was checked by spang@chromium.org
6 years, 9 months ago (2014-03-27 17:11:14 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/196403008/190001
6 years, 9 months ago (2014-03-27 17:11:55 UTC) #30
spang
6 years, 9 months ago (2014-03-27 17:25:34 UTC) #31
Message was sent while issue was closed.
Committed patchset #6 manually as r259923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698