src/heap/objects-visiting-inl.h - Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/objects-visiting-inl.h

Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: back to std::map Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/objects-visiting-inl.h

diff --git a/src/heap/objects-visiting-inl.h b/src/heap/objects-visiting-inl.h

index 4373451e44f45aa86ab14aa7e922974370216b3c..44f9170fb0c3a048ae71f07546e6010714b3a3f2 100644

--- a/src/heap/objects-visiting-inl.h

+++ b/src/heap/objects-visiting-inl.h

@@ -105,11 +105,6 @@ int StaticNewSpaceVisitor<StaticVisitor>::VisitJSArrayBuffer(

Map* map, HeapObject* object) {

typedef FlexibleBodyVisitor<StaticVisitor, JSArrayBuffer::BodyDescriptor, int>

JSArrayBufferBodyVisitor;

- if (!JSArrayBuffer::cast(object)->is_external()) {

- Heap* heap = map->GetHeap();

- heap->array_buffer_tracker()->MarkLive(JSArrayBuffer::cast(object));

- }

return JSArrayBufferBodyVisitor::Visit(map, object);

}