include/v8.h - Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: back to std::map Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 3079958d5868cb1182cae32223fa2677b8595b49..8b77e15d9670ff5efc7c98a4621dc63399ce5b9f 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -7357,7 +7357,7 @@ class Internals {

kAmountOfExternalAllocatedMemoryOffset + kApiInt64Size;

static const int kIsolateRootsOffset =

kAmountOfExternalAllocatedMemoryAtLastGlobalGCOffset + kApiInt64Size +

- kApiPointerSize;

+ kApiPointerSize + kApiPointerSize;

Hannes Payer (out of office) 2016/05/20 12:21:17 Why the extra word?

Michael Lippautz 2016/05/23 08:41:00 I added an intptr_t to Heap, changing the offset o

static const int kUndefinedValueRootIndex = 4;

static const int kTheHoleValueRootIndex = 5;

static const int kNullValueRootIndex = 6;