src/heap/scavenger.cc - Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/scavenger.cc

Issue 1964023002: [heap] Fine-grained JSArrayBuffer tracking (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix tests, harden expectations, more comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/scavenger.cc

diff --git a/src/heap/scavenger.cc b/src/heap/scavenger.cc

index 1d785d08d24232388be4d45603d68f9da313c22a..d7c3f2b9d0538878a2928b4b8ed51acc485a5fe3 100644

--- a/src/heap/scavenger.cc

+++ b/src/heap/scavenger.cc

@@ -295,7 +295,13 @@ class ScavengingVisitor : public StaticVisitorBase {

DCHECK(map_word.IsForwardingAddress());

HeapObject* target = map_word.ToForwardingAddress();

if (!heap->InNewSpace(target)) {

- heap->array_buffer_tracker()->Promote(JSArrayBuffer::cast(target));

+ heap->array_buffer_tracker()->Promote(

+ JSArrayBuffer::cast(target),

+ reinterpret_cast<JSArrayBuffer*>(object));

+ } else {

+ heap->array_buffer_tracker()->SemiSpaceCopy(

+ JSArrayBuffer::cast(target),

+ reinterpret_cast<JSArrayBuffer*>(object));

}