Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/Source/platform/heap/PersistentNode.cpp

Issue 1964013002: Handle overlapping CrossThreadPersistent<> releases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: drop unneeded PLATFORM_EXPORTs Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/PersistentNode.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/PersistentNode.cpp
diff --git a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
index 563f0fd7844b861ff5180cb20983623f600bd929..2c512958fed0f56d3fa88e42fe2b6710c21e5b8d 100644
--- a/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
+++ b/third_party/WebKit/Source/platform/heap/PersistentNode.cpp
@@ -159,8 +159,10 @@ void CrossThreadPersistentRegion::prepareForThreadStateTermination(ThreadState*
// but not invalidate its CrossThreadPersistent<>s.
if (page->orphaned())
continue;
- if (page->arena()->getThreadState() == threadState)
+ if (page->arena()->getThreadState() == threadState) {
persistent->clear();
+ ASSERT(slots->m_slot[i].isUnused());
+ }
}
slots = slots->m_next;
}
« no previous file with comments | « third_party/WebKit/Source/platform/heap/PersistentNode.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698