Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1964003002: unbundle: add GN files for flac, harfbuzz-ng, and libwebp (Closed)

Created:
4 years, 7 months ago by Paweł Hajdan Jr.
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

unbundle: add GN files for flac, harfbuzz-ng, and libwebp BUG=551343 Committed: https://crrev.com/9feb890d9d9d48beac0f0fd88c3eed18ebe56e6d Cr-Commit-Position: refs/heads/master@{#392879}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
A build/linux/unbundle/flac.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A build/linux/unbundle/harfbuzz-ng.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A + build/linux/unbundle/libwebp.gn View 1 chunk +5 lines, -2 lines 0 comments Download
M build/linux/unbundle/replace_gn_files.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/generate_shim_headers/generate_shim_headers.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Paweł Hajdan Jr.
4 years, 7 months ago (2016-05-10 14:19:36 UTC) #2
brettw
lgtm
4 years, 7 months ago (2016-05-10 17:09:54 UTC) #3
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-05-10 21:02:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964003002/1
4 years, 7 months ago (2016-05-11 08:02:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 08:34:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 08:36:19 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9feb890d9d9d48beac0f0fd88c3eed18ebe56e6d
Cr-Commit-Position: refs/heads/master@{#392879}

Powered by Google App Engine
This is Rietveld 408576698