Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1963973002: Makes BatteryDispatcher use the blink style mojo bindings. (Closed)

Created:
4 years, 7 months ago by Yuki
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes BatteryDispatcher use the blink style mojo bindings. BUG=610417 Committed: https://crrev.com/c1e46ccca220a3735ce9bbd2312ce80b987361f8 Cr-Commit-Position: refs/heads/master@{#392910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M device/battery/battery.gyp View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Yuki
sammc@, could you review this CL as an expert of Mojo? Am I following the ...
4 years, 7 months ago (2016-05-10 12:31:59 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-10 23:22:00 UTC) #3
Sam McNally
lgtm
4 years, 7 months ago (2016-05-11 00:46:53 UTC) #4
Yuki
timvolodine@, could you review this CL as the owner of device/battery/ ?
4 years, 7 months ago (2016-05-11 01:39:23 UTC) #6
timvolodine
On 2016/05/11 01:39:23, Yuki wrote: > timvolodine@, could you review this CL as the owner ...
4 years, 7 months ago (2016-05-11 12:28:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963973002/1
4 years, 7 months ago (2016-05-11 12:29:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 13:43:28 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 13:45:28 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1e46ccca220a3735ce9bbd2312ce80b987361f8
Cr-Commit-Position: refs/heads/master@{#392910}

Powered by Google App Engine
This is Rietveld 408576698