Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1963933002: [Media Router WebUI] Run afterNextRender() before tests using media-router-container. (Closed)

Created:
4 years, 7 months ago by apacible
Modified:
4 years, 7 months ago
Reviewers:
imcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Run afterNextRender() before tests using media-router-container. There's a race condition where afterNextRender() is not always called before setTimeout(). This causes flaky tests. All tests that use media-router-container, which uses afterNextRender() as part of its setup, should be run after an afterNextRender() call rather than setTimeout(). This will ensure setup completion, including registering listeners. BUG=610547 Committed: https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1 Cr-Commit-Position: refs/heads/master@{#392668}

Patch Set 1 : #

Messages

Total messages: 12 (7 generated)
apacible
PTAL, thanks!
4 years, 7 months ago (2016-05-10 03:23:20 UTC) #5
imcheng
lgtm
4 years, 7 months ago (2016-05-10 18:19:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963933002/40001
4 years, 7 months ago (2016-05-10 18:29:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 7 months ago (2016-05-10 19:04:42 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 19:06:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6101899d9c383af3e47801dc11dc594df43555c1
Cr-Commit-Position: refs/heads/master@{#392668}

Powered by Google App Engine
This is Rietveld 408576698