Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1963883002: mojo: make libmojo_public_test_support a static library. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: make libmojo_public_test_support a static library. The plan is to eventually get rid of it completely, but for now, we want to remove ODR violations related to MOJO_TEST_SUPPORT_EXPORT macro in non-components build. This is a second attempt to land the CL. The first one: https://codereview.chromium.org/1953503004/ The problem was a typo in mojo_shell_unittests.isolate, which is now fixed. BUG=609564, 515347, 610020 Committed: https://crrev.com/da412f2ccdbb6fdc5e1373bb7bedc8ace040aeae Cr-Commit-Position: refs/heads/master@{#392479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -115 lines) Patch
M mojo/common/BUILD.gn View 2 chunks +0 lines, -12 lines 0 comments Download
D mojo/mojo.isolate View 1 chunk +0 lines, -31 lines 0 comments Download
M mojo/mojo_common_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_integration_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_js_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public.gyp View 2 chunks +1 line, -17 lines 0 comments Download
M mojo/mojo_public_bindings_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_public_system_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_system_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/test_support/BUILD.gn View 1 chunk +2 lines, -11 lines 0 comments Download
M mojo/public/c/test_support/test_support.h View 3 chunks +2 lines, -5 lines 0 comments Download
D mojo/public/c/test_support/test_support_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M mojo/public/tests/test_support_private.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/mojo_shell_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download
M tools/cfi/blacklist.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
krasin
Hi Ken, I had to revert my CL last time, please, approve its relanding. The ...
4 years, 7 months ago (2016-05-09 22:48:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963883002/1
4 years, 7 months ago (2016-05-09 22:48:41 UTC) #4
Ken Rockot(use gerrit already)
Thanks again. LGTM
4 years, 7 months ago (2016-05-09 22:49:11 UTC) #5
krasin1
As usual, I made this CL from a wrong account (@google.com). Self-LGTM to propagate OWNERs ...
4 years, 7 months ago (2016-05-09 22:51:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963883002/1
4 years, 7 months ago (2016-05-09 22:52:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 23:50:36 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:51:41 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da412f2ccdbb6fdc5e1373bb7bedc8ace040aeae
Cr-Commit-Position: refs/heads/master@{#392479}

Powered by Google App Engine
This is Rietveld 408576698