Fix promise resolution of FontFaceSet#load()

Source/bindings/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 274 matching lines @@
 {
     v8::Local<v8::Array> result = v8::Array::New(isolate, iterator.size());
     int index = 0;
     typename HeapVector<T, inlineCapacity>::const_iterator end = iterator.end();
     typedef V8ValueTraits<T> TraitsType;
     for (typename HeapVector<T, inlineCapacity>::const_iterator iter = iterator.begin(); iter != end; ++iter)
         result->Set(v8::Integer::New(isolate, index++), TraitsType::arrayV8Value(*iter, isolate));
     return result;
 }
 
+template<typename T, size_t inlineCapacity>
+v8::Handle<v8::Value> v8ArrayNoInline(const Vector<T, inlineCapacity>& iterator, v8::Isolate* isolate)

[haraken, 2014/03/19 08:31:58]

I don't fully understand why you call this v8Array"NoInline". It's inlined.

Doesn't normal v8Array() work for you?

[Kunihiko Sakamoto, 2014/03/19 09:12:17]

Because this uses toV8NoInline(T) instead of toV8(T).
This function itself is inlined indeed ^^; any suggestions for naming?

Normal v8Array doesn't work. This code is used from FontFaceSet.cpp, and
toV8(FontFace) is defined in generated V8FontFace.h. We don't want to include
generated headers from Source/core. (see discussions in crbug.com/321569)

+{
+    v8::Local<v8::Array> result = v8::Array::New(isolate, iterator.size());
+    int index = 0;
+    typename Vector<T, inlineCapacity>::const_iterator end = iterator.end();
+    for (typename Vector<T, inlineCapacity>::const_iterator iter = iterator.begin(); iter != end; ++iter)
+        result->Set(v8::Integer::New(isolate, index++), toV8NoInline(WTF::getPtr(*iter), v8::Handle<v8::Object>(), isolate));
+    return result;
+}
+
 // Conversion flags, used in toIntXX/toUIntXX.
 enum IntegerConversionConfiguration {
     NormalConversion,
     EnforceRange,
     Clamp
 };
 
 // Convert a value to a 8-bit signed integer. The conversion fails if the
 // value cannot be converted to a number or the range violated per WebIDL:
 // http://www.w3.org/TR/WebIDL/#es-byte
@@ skipping 434 matching lines @@
     v8::HandleScope m_handleScope;
     v8::Handle<v8::Context> m_context;
     v8::Context::Scope m_contextScope;
     RefPtr<DOMWrapperWorld> m_world;
     OwnPtr<V8PerContextData> m_perContextData;
 };
 
 } // namespace WebCore
 
 #endif // V8Binding_h