Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 196383018: Check elimination now sets known successor branch of HCompareObjectEqAndBranch (correctness fix). (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Check elimination now sets known successor branch of HCompareObjectEqAndBranch (correctness fix). BUG=chromium:352058 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M src/hydrogen-check-elimination.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +10 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-352058.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-14 15:05:24 UTC) #1
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-17 08:12:50 UTC) #2
Igor Sheludko
6 years, 9 months ago (2014-03-17 09:11:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698