Issue 196383015: Move profiler callback interfaces from v8.h to v8-profiler.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196383015: Move profiler callback interfaces from v8.h to v8-profiler.h (Closed)

Created:
6 years, 9 months ago by yurys

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne, alph, loislo

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move profiler callback interfaces from v8.h to v8-profiler.h OutputStream and ActivityControl are used only by heap profiler so I moved their definition in v8-profiler.h to not clutter v8.h Drive-by: removed OutputStream::GetOutputEncoding which is unused. BUG=None LOG=Y R=alph@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19955

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -68 lines)			Patch
M	include/v8.h	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	include/v8-profiler.h	View	4 chunks	+52 lines, -4 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 9 months ago (2014-03-17 07:02:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19955 (presubmit successful).

Expand Messages | Collapse Messages