Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196383014: Remove window/host accessors from WED; IWYU for WTH (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky, danakj1
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, ben+aura_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, penghuang+watch_chromium.org, feature-media-reviews_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, ben+views_chromium.org, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, ben+corewm_chromium.org, danakj+watch_chromium.org, James Su, ben+ash_chromium.org
Visibility:
Public.

Description

Remove window/host accessors from WindowEventDispatcher. Include-What-You-Use for WindowTreeHost. TBR=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258401

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -144 lines) Patch
M ash/accelerators/key_hold_detector.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ash/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_controller.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +3 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_interactive_uitest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/boot_splash_screen_chromeos.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_kde.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_resize_lock_aura.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/compositor_resize_lock_aura.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_aura.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/default_capture_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aura.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurawin.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurax11.cc View 1 2 3 4 10 chunks +21 lines, -21 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +4 lines, -8 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +10 lines, -2 lines 0 comments Download
M ui/aura/window_targeter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/keyboard/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_ui_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 3 4 5 6 7 8 8 chunks +17 lines, -14 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/event_utils_aura.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_capture_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 2 3 4 5 6 chunks +7 lines, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_util_aurawin.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/capture_controller.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/core/input_method_event_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-14 23:07:11 UTC) #1
Ben Goodger (Google)
6 years, 9 months ago (2014-03-18 23:10:02 UTC) #2
danakj1
On Fri, Mar 14, 2014 at 7:07 PM, <ben@chromium.org> wrote: > Reviewers: sky, > > ...
6 years, 9 months ago (2014-03-18 23:47:16 UTC) #3
Ben Goodger (Google)
6 years, 9 months ago (2014-03-20 20:55:03 UTC) #4
Message was sent while issue was closed. 
Committed patchset #12 manually as r258401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698