Refactor GpuVideoDecoder::Factories out of GpuVideoDecoder.

media/filters/gpu_video_decoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_GPU_VIDEO_DECODER_H_
 #define MEDIA_FILTERS_GPU_VIDEO_DECODER_H_
 
 #include <list>
 #include <map>
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/memory/weak_ptr.h"
 #include "media/base/pipeline_status.h"
 #include "media/base/video_decoder.h"
+#include "media/filters/gpu_video_decoder_factories.h"

[scherkus (not reviewing), 2013/07/19 18:00:54]

ditto

[wuchengli, 2013/07/20 03:15:47]

Done.

 #include "media/video/video_decode_accelerator.h"
 
 template <class T> class scoped_refptr;
 
 namespace base {
 class MessageLoopProxy;
 class SharedMemory;
 }
 
-class SkBitmap;
-
 namespace media {
 
 class DecoderBuffer;
 class VDAClientProxy;
 
 // GPU-accelerated video decoder implementation.  Relies on
 // AcceleratedVideoDecoderMsg_Decode and friends.
 // All methods internally trampoline to the |message_loop| passed to the ctor.
 class MEDIA_EXPORT GpuVideoDecoder
     : public VideoDecoder,
       public VideoDecodeAccelerator::Client {
  public:
-  // Helper interface for specifying factories needed to instantiate a
-  // GpuVideoDecoder.
-  class MEDIA_EXPORT Factories : public base::RefCountedThreadSafe<Factories> {
-   public:
-    // Caller owns returned pointer.
-    virtual VideoDecodeAccelerator* CreateVideoDecodeAccelerator(
-        VideoCodecProfile, VideoDecodeAccelerator::Client*) = 0;
-
-    // Allocate & delete native textures.
-    virtual uint32 CreateTextures(int32 count, const gfx::Size& size,
-                                  std::vector<uint32>* texture_ids,
-                                  std::vector<gpu::Mailbox>* texture_mailboxes,
-                                  uint32 texture_target) = 0;
-    virtual void DeleteTexture(uint32 texture_id) = 0;
-
-    virtual void WaitSyncPoint(uint32 sync_point) = 0;
-
-    // Read pixels from a native texture and store into |pixels| as RGBA.
-    virtual void ReadPixels(uint32 texture_id, uint32 texture_target,
-                            const gfx::Size& size, const SkBitmap& pixels) = 0;
-
-    // Allocate & return a shared memory segment.  Caller is responsible for
-    // Close()ing the returned pointer.
-    virtual base::SharedMemory* CreateSharedMemory(size_t size) = 0;
-
-    // Returns the message loop the VideoDecodeAccelerator runs on.
-    virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoop() = 0;
-
-    // Abort any outstanding factory operations and error any future
-    // attempts at factory operations
-    virtual void Abort() = 0;
-
-    // Returns true if Abort() has been called.
-    virtual bool IsAborted() = 0;
-
-   protected:
-    friend class base::RefCountedThreadSafe<Factories>;
-    virtual ~Factories();
-  };
-
   GpuVideoDecoder(const scoped_refptr<base::MessageLoopProxy>& message_loop,
-                  const scoped_refptr<Factories>& factories);
+                  const scoped_refptr<GpuVideoDecoderFactories>& factories);
 
   // VideoDecoder implementation.
   virtual void Initialize(const VideoDecoderConfig& config,
                           const PipelineStatusCB& status_cb) OVERRIDE;
   virtual void Decode(const scoped_refptr<DecoderBuffer>& buffer,
                       const ReadCB& read_cb) OVERRIDE;
   virtual void Reset(const base::Closure& closure) OVERRIDE;
   virtual void Stop(const base::Closure& closure) OVERRIDE;
   virtual bool HasAlpha() const OVERRIDE;
   virtual bool NeedsBitstreamConversion() const OVERRIDE;
@@ skipping 73 matching lines @@
   // if they arrive on other loops.
   scoped_refptr<base::MessageLoopProxy> gvd_loop_proxy_;
   base::WeakPtrFactory<GpuVideoDecoder> weak_factory_;
   base::WeakPtr<GpuVideoDecoder> weak_this_;
 
   // Message loop on which to makes all calls to vda_.  (beware this loop may be
   // paused during the Pause/Flush/Stop dance PipelineImpl::Stop() goes
   // through).
   scoped_refptr<base::MessageLoopProxy> vda_loop_proxy_;
 
-  scoped_refptr<Factories> factories_;
+  scoped_refptr<GpuVideoDecoderFactories> factories_;
 
   // Proxies calls from |vda_| to |gvd_loop_proxy_| and used to safely detach
   // during shutdown.
   scoped_refptr<VDAClientProxy> client_proxy_;
 
   // Populated during Initialize() via SetVDA() (on success) and unchanged
   // until an error occurs.
   scoped_ptr<VideoDecodeAccelerator> vda_;
   // Used to post tasks from the GVD thread to the VDA thread safely.
   base::WeakPtr<VideoDecodeAccelerator> weak_vda_;
@@ skipping 53 matching lines @@
   // Set during ProvidePictureBuffers(), used for checking and implementing
   // HasAvailableOutputFrames().
   int available_pictures_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuVideoDecoder);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_GPU_VIDEO_DECODER_H_