Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Side by Side Diff: content/renderer/media/webmediaplayer_params.h

Issue 19638008: Refactor GpuVideoDecoder::Factories out of GpuVideoDecoder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_
6 #define CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_ 6 #define CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "media/filters/gpu_video_decoder.h" 9 #include "media/filters/gpu_video_decoder.h"
scherkus (not reviewing) 2013/07/19 18:00:54 ditto
wuchengli 2013/07/20 03:15:47 Done.
10 10
11 namespace base { 11 namespace base {
12 class MessageLoopProxy; 12 class MessageLoopProxy;
13 } 13 }
14 14
15 namespace media { 15 namespace media {
16 class AudioRendererSink; 16 class AudioRendererSink;
17 class MediaLog; 17 class MediaLog;
18 } 18 }
19 19
20 namespace content { 20 namespace content {
21 21
22 // Holds parameters for constructing WebMediaPlayerImpl without having 22 // Holds parameters for constructing WebMediaPlayerImpl without having
23 // to plumb arguments through various abstraction layers. 23 // to plumb arguments through various abstraction layers.
24 class WebMediaPlayerParams { 24 class WebMediaPlayerParams {
25 public: 25 public:
26 // |message_loop_proxy| and |media_log| are the only required parameters; 26 // |message_loop_proxy| and |media_log| are the only required parameters;
27 // all others may be null. 27 // all others may be null.
28 WebMediaPlayerParams( 28 WebMediaPlayerParams(
29 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy, 29 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy,
30 const base::Callback<void(const base::Closure&)>& defer_load_cb, 30 const base::Callback<void(const base::Closure&)>& defer_load_cb,
31 const scoped_refptr<media::AudioRendererSink>& audio_renderer_sink, 31 const scoped_refptr<media::AudioRendererSink>& audio_renderer_sink,
32 const scoped_refptr<media::GpuVideoDecoder::Factories>& gpu_factories, 32 const scoped_refptr<media::GpuVideoDecoderFactories>& gpu_factories,
33 const scoped_refptr<media::MediaLog>& media_log); 33 const scoped_refptr<media::MediaLog>& media_log);
34 ~WebMediaPlayerParams(); 34 ~WebMediaPlayerParams();
35 35
36 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy() const { 36 const scoped_refptr<base::MessageLoopProxy>& message_loop_proxy() const {
37 return message_loop_proxy_; 37 return message_loop_proxy_;
38 } 38 }
39 39
40 base::Callback<void(const base::Closure&)> defer_load_cb() const { 40 base::Callback<void(const base::Closure&)> defer_load_cb() const {
41 return defer_load_cb_; 41 return defer_load_cb_;
42 } 42 }
43 43
44 const scoped_refptr<media::AudioRendererSink>& audio_renderer_sink() const { 44 const scoped_refptr<media::AudioRendererSink>& audio_renderer_sink() const {
45 return audio_renderer_sink_; 45 return audio_renderer_sink_;
46 } 46 }
47 47
48 const scoped_refptr<media::GpuVideoDecoder::Factories>& 48 const scoped_refptr<media::GpuVideoDecoderFactories>& gpu_factories() const {
49 gpu_factories() const {
50 return gpu_factories_; 49 return gpu_factories_;
51 } 50 }
52 51
53 const scoped_refptr<media::MediaLog>& media_log() const { 52 const scoped_refptr<media::MediaLog>& media_log() const {
54 return media_log_; 53 return media_log_;
55 } 54 }
56 55
57 private: 56 private:
58 scoped_refptr<base::MessageLoopProxy> message_loop_proxy_; 57 scoped_refptr<base::MessageLoopProxy> message_loop_proxy_;
59 base::Callback<void(const base::Closure&)> defer_load_cb_; 58 base::Callback<void(const base::Closure&)> defer_load_cb_;
60 scoped_refptr<media::AudioRendererSink> audio_renderer_sink_; 59 scoped_refptr<media::AudioRendererSink> audio_renderer_sink_;
61 scoped_refptr<media::GpuVideoDecoder::Factories> gpu_factories_; 60 scoped_refptr<media::GpuVideoDecoderFactories> gpu_factories_;
62 scoped_refptr<media::MediaLog> media_log_; 61 scoped_refptr<media::MediaLog> media_log_;
63 62
64 DISALLOW_IMPLICIT_CONSTRUCTORS(WebMediaPlayerParams); 63 DISALLOW_IMPLICIT_CONSTRUCTORS(WebMediaPlayerParams);
65 }; 64 };
66 65
67 } // namespace media 66 } // namespace media
68 67
69 #endif // CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_ 68 #endif // CONTENT_RENDERER_MEDIA_WEBMEDIAPLAYER_PARAMS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698