Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: src/accessors.cc

Issue 19638003: Handlify Accessors::FunctionGetArguments method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Minor adjustments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 ReadOnlySetAccessor, 569 ReadOnlySetAccessor,
570 0 570 0
571 }; 571 };
572 572
573 573
574 // 574 //
575 // Accessors::FunctionArguments 575 // Accessors::FunctionArguments
576 // 576 //
577 577
578 578
579 Handle<Object> Accessors::FunctionGetArguments(Handle<Object> object) {
580 Isolate* isolate = Isolate::Current();
581 CALL_HEAP_FUNCTION(
582 isolate, Accessors::FunctionGetArguments(*object, 0), Object);
Yang 2013/07/18 12:21:18 The call sites always have a comment that this can
Michael Starzinger 2013/07/18 13:01:03 See comment in the header.
583 }
584
585
579 static MaybeObject* ConstructArgumentsObjectForInlinedFunction( 586 static MaybeObject* ConstructArgumentsObjectForInlinedFunction(
580 JavaScriptFrame* frame, 587 JavaScriptFrame* frame,
581 Handle<JSFunction> inlined_function, 588 Handle<JSFunction> inlined_function,
582 int inlined_frame_index) { 589 int inlined_frame_index) {
583 Isolate* isolate = inlined_function->GetIsolate(); 590 Isolate* isolate = inlined_function->GetIsolate();
584 Factory* factory = isolate->factory(); 591 Factory* factory = isolate->factory();
585 Vector<SlotRef> args_slots = 592 Vector<SlotRef> args_slots =
586 SlotRef::ComputeSlotMappingForArguments( 593 SlotRef::ComputeSlotMappingForArguments(
587 frame, 594 frame,
588 inlined_frame_index, 595 inlined_frame_index,
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
842 info->set_data(Smi::FromInt(index)); 849 info->set_data(Smi::FromInt(index));
843 Handle<Object> getter = v8::FromCData(&ModuleGetExport); 850 Handle<Object> getter = v8::FromCData(&ModuleGetExport);
844 Handle<Object> setter = v8::FromCData(&ModuleSetExport); 851 Handle<Object> setter = v8::FromCData(&ModuleSetExport);
845 info->set_getter(*getter); 852 info->set_getter(*getter);
846 if (!(attributes & ReadOnly)) info->set_setter(*setter); 853 if (!(attributes & ReadOnly)) info->set_setter(*setter);
847 return info; 854 return info;
848 } 855 }
849 856
850 857
851 } } // namespace v8::internal 858 } } // namespace v8::internal
OLDNEW
« src/accessors.h ('K') | « src/accessors.h ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698