Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1963773002: clang tot bots: Update to cmake 3.4.3 (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, yunlian, hans, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang tot bots: Update to cmake 3.4.3 The 3.4.3 zip file is identical to the 3.4.3 Windows zip on cmake.org. The Linux file is almost identical except that I removed doc/cmake/html and bin/ccmake and bin/cmake-gui. Mac is just the doc/, bin/, share/ folders in CMake.app/Contents (again with doc/cmake/html and ccmake and cmake-gui removed). BUG=609162 Committed: https://crrev.com/ffe3e65a4d58f809a85d3716ead7daa9aa9df4ae Cr-Commit-Position: refs/heads/master@{#392380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
4 years, 7 months ago (2016-05-09 17:43:54 UTC) #2
hans
lgtm Maybe note in the commit message that the Mac package was built on 10.9 ...
4 years, 7 months ago (2016-05-09 17:48:06 UTC) #3
Nico
I didn't build it myself, I got it from cmake.org and that page claims "10.6+"
4 years, 7 months ago (2016-05-09 17:49:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963773002/1
4 years, 7 months ago (2016-05-09 18:02:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 18:44:22 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:45:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffe3e65a4d58f809a85d3716ead7daa9aa9df4ae
Cr-Commit-Position: refs/heads/master@{#392380}

Powered by Google App Engine
This is Rietveld 408576698