Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 1963753003: DevTools: default all console object previews to lossy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 53c190c528b25aba3bf657a8c0c1c3d74f5da820..a94f6bf7ecccd36ba4462e5034b764deaf67723f 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -411,12 +411,7 @@ WebInspector.ConsoleViewMessage.prototype = {
var titleElement = createElement("span");
if (includePreview && obj.preview) {
titleElement.classList.add("console-object-preview");
- var lossless = this._previewFormatter.appendObjectPreview(titleElement, obj.preview);
- if (lossless) {
- elem.appendChild(titleElement);
- titleElement.addEventListener("contextmenu", this._contextMenuEventFired.bind(this, obj), false);
- return;
- }
+ this._previewFormatter.appendObjectPreview(titleElement, obj.preview);
} else {
if (obj.type === "function") {
WebInspector.ObjectPropertiesSection.formatObjectAsFunction(obj, titleElement, false);
@@ -587,11 +582,9 @@ WebInspector.ConsoleViewMessage.prototype = {
}
var dataGridContainer = element.createChild("span");
- if (!preview.lossless || !flatValues.length) {
- element.appendChild(this._formatParameter(table, true, false));
- if (!flatValues.length)
- return element;
- }
+ element.appendChild(this._formatParameter(table, true, false));
+ if (!flatValues.length)
+ return element;
columnNames.unshift(WebInspector.UIString("(index)"));
var dataGrid = WebInspector.SortableDataGrid.create(columnNames, flatValues);

Powered by Google App Engine
This is Rietveld 408576698