DevTools: default all console object previews to lossy

third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 794 matching lines @@
         this.objectId = injectedScript._bind(object, objectGroupName);
     var subtype = injectedScript._subtype(object);
     if (subtype)
         this.subtype = subtype;
     var className = InjectedScriptHost.internalConstructorName(object);
     if (className)
         this.className = className;
     this.description = injectedScript._describe(object);
 
     if (generatePreview && this.type === "object") {
         if (this.subtype === "proxy") {

[kozy, 2016/05/10 00:04:42]

please remove brackets

[luoe, 2016/05/10 17:27:45]

Done.

             this.preview = this._generatePreview(InjectedScriptHost.proxyTargetValue(object), undefined, columnNames, isTable, skipEntriesPreview);
-            this.preview.lossless = false;
         } else if (this.subtype !== "node") {
             this.preview = this._generatePreview(object, undefined, columnNames, isTable, skipEntriesPreview);
         }
     }
 
     if (injectedScript._customObjectFormatterEnabled) {
         var customPreview = this._customPreview(object, objectGroupName, customObjectConfig);
         if (customPreview)
             this.customPreview = customPreview;
     }
@@ skipping 46 matching lines @@
     },
 
     /**
      * @return {!RuntimeAgent.ObjectPreview} preview
      */
     _createEmptyPreview: function()
     {
         var preview = {
             type: /** @type {!RuntimeAgent.ObjectPreviewType.<string>} */ (this.type),
             description: this.description || toStringDescription(this.value),
-            lossless: true,
             overflow: false,
             properties: [],
             __proto__: null
         };
         if (this.subtype)
             preview.subtype = /** @type {!RuntimeAgent.ObjectPreviewSubtype.<string>} */ (this.subtype);
         return preview;
     },
 
     /**
@@ skipping 32 matching lines @@
                     isOwn: true,
                     enumerable: true,
                     __proto__: null
                 });
             }
             this._appendPropertyDescriptors(preview, internalProperties, propertiesThreshold, secondLevelKeys, isTable);
 
             if (this.subtype === "map" || this.subtype === "set" || this.subtype === "iterator")
                 this._appendEntriesPreview(object, preview, skipEntriesPreview);
 
-        } catch (e) {
-            preview.lossless = false;
-        }
+        } catch (e) {}
 
         return preview;
     },
 
     /**
      * @param {!RuntimeAgent.ObjectPreview} preview
      * @param {!Array.<*>|!Iterable.<*>} descriptors
      * @param {!Object} propertiesThreshold
      * @param {?Array.<string>=} secondLevelKeys
      * @param {boolean=} isTable
      */
     _appendPropertyDescriptors: function(preview, descriptors, propertiesThreshold, secondLevelKeys, isTable)
     {
         for (var descriptor of descriptors) {
             if (propertiesThreshold.indexes < 0 || propertiesThreshold.properties < 0)
                 break;
-            if (!descriptor)
-                continue;
-            if (descriptor.wasThrown) {
-                preview.lossless = false;
+            if (!descriptor || descriptor.wasThrown) {

[kozy, 2016/05/10 00:04:42]

ditto

[luoe, 2016/05/10 17:27:45]

Done.

                 continue;
             }
 
             var name = descriptor.name;
 
-            // Ignore __proto__ property, stay lossless.
+            // Ignore __proto__ property.
             if (name === "__proto__")
                 continue;
 
-            // Ignore non-enumerable members on prototype, stay lossless.
-            if (!descriptor.isOwn && !descriptor.enumerable)

[kozy, 2016/05/10 00:04:42]

Bring it back and remove following descriptor.isOwn check.

[luoe, 2016/05/10 17:27:45]

That would allow enumerable props on the prototype to be included (isOwn: false,
enumerable: true) in the appending, which is different than the logic before. 
Is that intended?

[kozy, 2016/05/11 00:54:18]

Yep, it's right. It's my fault.

-                continue;
-
-            // Ignore length property of array, stay lossless.
+            // Ignore length property of array.
             if (this.subtype === "array" && name === "length")
                 continue;
 
-            // Ignore size property of map, set, stay lossless.
+            // Ignore size property of map, set.
             if ((this.subtype === "map" || this.subtype === "set") && name === "size")
                 continue;
 
-            // Never preview prototype properties, turn lossy.
-            if (!descriptor.isOwn) {
-                preview.lossless = false;
+            // Never preview prototype properties.
+            if (!descriptor.isOwn)
                 continue;
-            }
 
-            // Ignore computed properties, turn lossy.
-            if (!("value" in descriptor)) {
-                preview.lossless = false;
+            // Ignore computed properties.
+            if (!("value" in descriptor))
                 continue;
-            }
 
             var value = descriptor.value;
             var type = typeof value;
 
-            // Never render functions in object preview, turn lossy
-            if (type === "function" && (this.subtype !== "array" || !isUInt32(name))) {
-                preview.lossless = false;
+            // Never render functions in object preview.
+            if (type === "function" && (this.subtype !== "array" || !isUInt32(name)))
                 continue;
-            }
 
             // Special-case HTMLAll.
             if (type === "undefined" && injectedScript._isHTMLAllCollection(value))
                 type = "object";
 
             // Render own properties.
             if (value === null) {
                 this._appendPropertyPreview(preview, { name: name, type: "object", subtype: "null", value: "null", __proto__: null }, propertiesThreshold);
                 continue;
             }
 
             var maxLength = 100;
             if (InjectedScript.primitiveTypes[type]) {
-                if (type === "string" && value.length > maxLength) {
+                if (type === "string" && value.length > maxLength)
                     value = this._abbreviateString(value, maxLength, true);
-                    preview.lossless = false;
-                }
                 this._appendPropertyPreview(preview, { name: name, type: type, value: toStringDescription(value), __proto__: null }, propertiesThreshold);
                 continue;
             }
 
             var property = { name: name, type: type, __proto__: null };
             var subtype = injectedScript._subtype(value);
             if (subtype)
                 property.subtype = subtype;
 
             if (secondLevelKeys === null || secondLevelKeys) {
                 var subPreview = this._generatePreview(value, secondLevelKeys || undefined, undefined, isTable);
                 property.valuePreview = subPreview;
-                if (!subPreview.lossless)
-                    preview.lossless = false;
                 if (subPreview.overflow)
                     preview.overflow = true;
             } else {
                 var description = "";
                 if (type !== "function")
                     description = this._abbreviateString(/** @type {string} */ (injectedScript._describe(value)), maxLength, subtype === "regexp");
                 property.value = description;
-                preview.lossless = false;
             }
             this._appendPropertyPreview(preview, property, propertiesThreshold);
         }
     },
 
     /**
      * @param {!RuntimeAgent.ObjectPreview} preview
      * @param {!Object} property
      * @param {!Object} propertiesThreshold
      */
     _appendPropertyPreview: function(preview, property, propertiesThreshold)
     {
         if (toString(property.name >>> 0) === property.name)
             propertiesThreshold.indexes--;
         else
             propertiesThreshold.properties--;
         if (propertiesThreshold.indexes < 0 || propertiesThreshold.properties < 0) {
             preview.overflow = true;
-            preview.lossless = false;
         } else {
             push(preview.properties, property);
         }
     },
 
     /**
      * @param {!Object} object
      * @param {!RuntimeAgent.ObjectPreview} preview
      * @param {boolean=} skipEntriesPreview
      */
     _appendEntriesPreview: function(object, preview, skipEntriesPreview)
     {
         var entries = InjectedScriptHost.collectionEntries(object);
         if (!entries)
             return;
         if (skipEntriesPreview) {
             if (entries.length) {

[kozy, 2016/05/10 00:04:42]

please remove brackets

[luoe, 2016/05/10 17:27:45]

Done.

                 preview.overflow = true;
-                preview.lossless = false;
             }
             return;
         }
         preview.entries = [];
         var entriesThreshold = 5;
         for (var i = 0; i < entries.length; ++i) {
             if (preview.entries.length >= entriesThreshold) {
                 preview.overflow = true;
-                preview.lossless = false;
                 break;
             }
             var entry = nullifyObjectProto(entries[i]);
             var previewEntry = {
                 value: generateValuePreview(entry.value),
                 __proto__: null
             };
             if ("key" in entry)
                 previewEntry.key = generateValuePreview(entry.key);
             push(preview.entries, previewEntry);
         }
 
         /**
          * @param {*} value
          * @return {!RuntimeAgent.ObjectPreview}
          */
         function generateValuePreview(value)
         {
             var remoteObject = new InjectedScript.RemoteObject(value, undefined, true, undefined, true, undefined, undefined, true);
             var valuePreview = remoteObject.preview || remoteObject._createEmptyPreview();
-            if (!valuePreview.lossless)
-                preview.lossless = false;
             return valuePreview;
         }
     },
 
     /**
      * @param {string} string
      * @param {number} maxLength
      * @param {boolean=} middle
      * @return {string}
      */
@@ skipping 181 matching lines @@
 /**
  * @param {!Event} event
  */
 CommandLineAPIImpl._logEvent = function(event)
 {
     inspectedGlobalObject.console.log(event.type, event);
 }
 
 return injectedScript;
 })