DevTools: default all console object previews to lossy

DevTools: default all console object previews to lossy

BUG=607679
Committed: https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de
Cr-Commit-Position: refs/heads/master@{#394626}

[luoe, 2016-05-09 22:51:20]

Description was changed from

==========
DevTools: default all console object previews to lossy

BUG=607679
==========

to

==========
DevTools: default all console object previews to lossy

BUG=607679
==========

[luoe, 2016-05-09 22:51:20]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[luoe, 2016-05-09 22:51:45]

Inspector tests should all be passing.  Ready for review.

[kozy, 2016-05-10 00:04:42]

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:456:
.console-view-object-properties-section {
Please wait for @lushnikov review of this.

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(left):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:970: if
(!descriptor.isOwn && !descriptor.enumerable)
Bring it back and remove following descriptor.isOwn check.

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:815: if
(this.subtype === "proxy") {
please remove brackets

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:952: if
(!descriptor || descriptor.wasThrown) {
ditto

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1052: if
(entries.length) {
please remove brackets

[kozy, 2016-05-10 00:05:32]

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/Inspector-1.1.json (left):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/Inspector-1.1.json:639: { "name": "lossless",
"type": "boolean", "description": "Determines whether preview is lossless
(contains all information of the original object)." },
And revert it please! We never change released protocol.json.

[kozy, 2016-05-10 00:08:39]

kozyatinskiy@chromium.org changed reviewers:
+ lushnikov@chromium.org

[kozy, 2016-05-10 00:08:55]

Added Andrey for css and frontend.

[luoe, 2016-05-10 17:27:46]

Brackets removed, inspector-1.1.json reverted.

Please see comment on the if condition

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/Inspector-1.1.json (left):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/Inspector-1.1.json:639: { "name": "lossless",
"type": "boolean", "description": "Determines whether preview is lossless
(contains all information of the original object)." },
On 2016/05/10 00:05:32, kozyatinskiy wrote:
> And revert it please! We never change released protocol.json.

Whoops sorry, I'll revert it back in!

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(left):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:970: if
(!descriptor.isOwn && !descriptor.enumerable)
On 2016/05/10 00:04:42, kozyatinskiy wrote:
> Bring it back and remove following descriptor.isOwn check.

That would allow enumerable props on the prototype to be included (isOwn: false,
enumerable: true) in the appending, which is different than the logic before. 
Is that intended?

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:815: if
(this.subtype === "proxy") {
On 2016/05/10 00:04:42, kozyatinskiy wrote:
> please remove brackets

Done.

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:952: if
(!descriptor || descriptor.wasThrown) {
On 2016/05/10 00:04:42, kozyatinskiy wrote:
> ditto

Done.

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:1052: if
(entries.length) {
On 2016/05/10 00:04:42, kozyatinskiy wrote:
> please remove brackets

Done.

[kozy, 2016-05-11 00:54:19]

lgtm,
please wait for @lushnikov's review.

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(left):

https://codereview.chromium.org/1963753003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:970: if
(!descriptor.isOwn && !descriptor.enumerable)
On 2016/05/10 17:27:45, luoe wrote:
> On 2016/05/10 00:04:42, kozyatinskiy wrote:
> > Bring it back and remove following descriptor.isOwn check.
> 
> That would allow enumerable props on the prototype to be included (isOwn:
false,
> enumerable: true) in the appending, which is different than the logic before. 
> Is that intended?

Yep, it's right. It's my fault.

[lushnikov, 2016-05-16 22:33:31]

lgtm

https://codereview.chromium.org/1963753003/diff/10014/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/1963753003/diff/10014/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:458:
margin-top: -1px;
let's not do margin -1px - the root cause of the problem might be somewhere in
vertical-align property

[luoe, 2016-05-16 22:45:49]

Style fixes coming in separate CL

https://codereview.chromium.org/1963753003/diff/10014/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/1963753003/diff/10014/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:458:
margin-top: -1px;
On 2016/05/16 22:33:31, lushnikov wrote:
> let's not do margin -1px - the root cause of the problem might be somewhere in
> vertical-align property

Done.

[luoe, 2016-05-17 00:12:17]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-17 00:12:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963753003/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963753003/70001

[commit-bot: I haz the power, 2016-05-17 01:36:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 01:36:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[luoe, 2016-05-18 20:38:30]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 20:38:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963753003/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963753003/90001

[commit-bot: I haz the power, 2016-05-18 22:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 22:12:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[luoe, 2016-05-18 23:39:38]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 23:40:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963753003/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963753003/90001

[commit-bot: I haz the power, 2016-05-19 00:45:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 00:45:04]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-05-19 01:03:31]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-05-19 01:03:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1963753003/#ps90001
(title: "Added missing return")

[commit-bot: I haz the power, 2016-05-19 01:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1963753003/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1963753003/90001

[commit-bot: I haz the power, 2016-05-19 01:11:50]

Description was changed from

==========
DevTools: default all console object previews to lossy

BUG=607679
==========

to

==========
DevTools: default all console object previews to lossy

BUG=607679
==========

[commit-bot: I haz the power, 2016-05-19 01:11:52]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-05-19 01:13:43]

Description was changed from

==========
DevTools: default all console object previews to lossy

BUG=607679
==========

to

==========
DevTools: default all console object previews to lossy

BUG=607679

Committed: https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de
Cr-Commit-Position: refs/heads/master@{#394626}
==========

[commit-bot: I haz the power, 2016-05-19 01:13:44]

Patchset 6 (id:??) landed as
https://crrev.com/9e1dd6173109704cf8df1ca0b3c1ea1ecc5305de
Cr-Commit-Position: refs/heads/master@{#394626}