Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1963753002: Disable tracing in user service (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, michaeln
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable tracing in user service Two problems: 1. The tracing client library makes some now-invalid assumptions about its environment 2. We don't have a tracing shell client setup properly for chrome or browser tests. The second problem in particular is causing bad behavior on OS X if anyone tries connecting to mojo:tracing. This CL removes tracing usage from UserShellClient for now. BUG=609632 R=erg@chromium.org Committed: https://crrev.com/ad48a137fd13bf0966c58f17b667f3828dcd89ed Cr-Commit-Position: refs/heads/master@{#392378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M services/user/user_shell_client.h View 2 chunks +0 lines, -3 lines 0 comments Download
M services/user/user_shell_client.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-09 17:27:26 UTC) #1
Elliot Glaysher
lgtm
4 years, 7 months ago (2016-05-09 17:44:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963753002/1
4 years, 7 months ago (2016-05-09 17:45:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 18:36:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:38:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad48a137fd13bf0966c58f17b667f3828dcd89ed
Cr-Commit-Position: refs/heads/master@{#392378}

Powered by Google App Engine
This is Rietveld 408576698