Faster ignore.

Faster ignore.

Put a cache in front of the function which tests for failures to
ignore.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/952d2ed96ac15acd21a269be45e20b514428b665

[Leaf, 2016-05-10 15:47:41]

leafp@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-05-10 15:56:10]

lgtm

https://codereview.chromium.org/1963733003/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/operations.dart (right):

https://codereview.chromium.org/1963733003/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/operations.dart:204: if (!!$isSubtype(type,
$Iterable) && !!$isSubtype(actual, $Iterable) ||
FWIW, for gt, I ended up replacing this with:

  var raw = $getGenericClass($type);
  if (raw && $isSubtype($actual, raw())) {
    console.warn(...);
    return true;
  }

[Leaf, 2016-05-10 16:43:05]

https://codereview.chromium.org/1963733003/diff/1/tool/input_sdk/private/ddc_...
File tool/input_sdk/private/ddc_runtime/operations.dart (right):

https://codereview.chromium.org/1963733003/diff/1/tool/input_sdk/private/ddc_...
tool/input_sdk/private/ddc_runtime/operations.dart:204: if (!!$isSubtype(type,
$Iterable) && !!$isSubtype(actual, $Iterable) ||
On 2016/05/10 15:56:10, vsm wrote:
> FWIW, for gt, I ended up replacing this with:
> 
>   var raw = $getGenericClass($type);
>   if (raw && $isSubtype($actual, raw())) {
>     console.warn(...);
>     return true;
>   }

Yeah, I started to optimize this, but it completely fell off the profile once I
added the cache. Still probably worth doing.

[Leaf, 2016-05-10 16:43:24]

Description was changed from

==========
Faster ignore.

Put a cache in front of the function which tests for failures to
ignore.

BUG=
==========

to

==========
Faster ignore.

Put a cache in front of the function which tests for failures to
ignore.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/952d2ed96ac15acd21a269be45e2...
==========

[Leaf, 2016-05-10 16:43:25]

Committed patchset #1 (id:1) manually as
952d2ed96ac15acd21a269be45e20b514428b665 (presubmit successful).