pkg/analysis_server/lib/src/analysis_server.dart - Issue 196373003: Change in the Dart command line analyzer, Logger.logError takes a String, not Error types. This wi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 196373003: Change in the Dart command line analyzer, Logger.logError takes a String, not Error types. This wi… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/analysis_server.dart

diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart

index 02a4f80f27a8a653a46a2075468adb5485c75d5c..eaccbaa8beb87ba08c5ab377f63a553c65c8ea9f 100644

--- a/pkg/analysis_server/lib/src/analysis_server.dart

+++ b/pkg/analysis_server/lib/src/analysis_server.dart

@@ -137,7 +137,7 @@ class AnalysisServer {

running = false;

} else {

new Future(performTask).catchError((exception, stackTrace) {

- AnalysisEngine.instance.logger.logError(exception);

+ AnalysisEngine.instance.logger.logError(exception.toString());

Brian Wilkerson 2014/03/12 13:19:18 We definitely want to log the stack trace.

jwren 2014/03/12 16:28:44 Done.

});

}

« no previous file with comments | « no previous file | pkg/analyzer/lib/src/analyzer_impl.dart » ('j') | pkg/analyzer/lib/src/analyzer_impl.dart » ('J')