Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1963703003: Adds `DartOptions` to generic method syntax tests (updated CL). (Closed)

Created:
4 years, 7 months ago by eernst
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adds `DartOptions` to generic method syntax tests (updated CL). This CL was landed and reverted. The bot failures caused by the first landing of this CL turned out to be caused by checked mode execution. This is an adjustment of that CL which marks the relevant tests as failing. The underlying issue is that the compiler phases after resolution do not expect to receive method type variables, only class type variables; that will be addressed in a separate CL. R=floitsch@google.com, johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/7da48f3a95a395f80a04f4df2010bd6e8a4bc502

Patch Set 1 #

Patch Set 2 : Changed RuntimeError to Crash #

Patch Set 3 : Rebased on fresh master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M tests/language/generic_functions_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_local_functions_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_methods_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_sends_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eernst
Marking some checked mode tests of generic method syntax as failing. The actual failure is ...
4 years, 7 months ago (2016-05-10 13:50:22 UTC) #2
eernst
On 2016/05/10 13:50:22, eernst wrote: > Marking some checked mode tests of generic method syntax ...
4 years, 7 months ago (2016-05-10 14:28:17 UTC) #3
floitsch
LGTM.
4 years, 7 months ago (2016-05-10 15:30:59 UTC) #5
Johnni Winther
lgtm
4 years, 7 months ago (2016-05-11 07:40:56 UTC) #6
eernst
4 years, 7 months ago (2016-05-11 07:46:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7da48f3a95a395f80a04f4df2010bd6e8a4bc502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698