Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1963633003: Revert of Pepper: Add a nullptr check. (Closed)

Created:
4 years, 7 months ago by ilja
Modified:
4 years, 7 months ago
Reviewers:
erikchen, piman, hshi1
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pepper: Add a nullptr check. (patchset #3 id:40001 of https://codereview.chromium.org/1951263003/ ) Reason for revert: Breaks WebGL on CrOS, crbug.com/610411. Original issue's description: > Pepper: Associate TextureMailboxes with the Graphics3D they were obtained from. > > This allows the TextureMailbox to be returned to the appropriate Graphics3D, > which implicitly deals with trying to return a TextureMailbox to a null > Graphics3D. > > BUG=602484 > > Committed: https://crrev.com/5fcc55335e3b5ba36a0de1a2e7a0976c859f6fff > Cr-Commit-Position: refs/heads/master@{#391934} TBR=piman@chromium.org,erikchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602484 Committed: https://crrev.com/e8e99f4cc7787cd52aad8f514a03db5aeadf1feb Cr-Commit-Position: refs/heads/master@{#392542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 4 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ilja
Created Revert of Pepper: Add a nullptr check.
4 years, 7 months ago (2016-05-10 02:16:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963633003/1
4 years, 7 months ago (2016-05-10 02:17:11 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-10 02:17:12 UTC) #4
hshi1
lgtm
4 years, 7 months ago (2016-05-10 02:20:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963633003/1
4 years, 7 months ago (2016-05-10 03:27:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 04:15:46 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 04:17:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8e99f4cc7787cd52aad8f514a03db5aeadf1feb
Cr-Commit-Position: refs/heads/master@{#392542}

Powered by Google App Engine
This is Rietveld 408576698