Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1963633002: [keys] fixing nested JSProxy for-in enumeration (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[keys] fixing nested JSProxy for-in enumeration BUG=chromium:610210 LOG=N Committed: https://crrev.com/da16609c1479240c0c4cf102321b9c553218184d Cr-Commit-Position: refs/heads/master@{#36144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -39 lines) Patch
M src/keys.h View 2 chunks +8 lines, -4 lines 0 comments Download
M src/keys.cc View 12 chunks +28 lines, -29 lines 0 comments Download
M test/mjsunit/es6/proxies-for.js View 1 chunk +11 lines, -6 lines 0 comments Download
M test/mjsunit/es6/proxies-keys.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Camillo Bruni
PTAL - some renaming in keys.cc - main fix is CollectJSProxyTargetKeys
4 years, 7 months ago (2016-05-09 11:20:01 UTC) #2
Igor Sheludko
lgtm
4 years, 7 months ago (2016-05-09 11:23:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963633002/1
4 years, 7 months ago (2016-05-10 06:51:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14913)
4 years, 7 months ago (2016-05-10 06:54:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963633002/1
4 years, 7 months ago (2016-05-10 14:20:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 14:26:26 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 14:26:58 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/da16609c1479240c0c4cf102321b9c553218184d
Cr-Commit-Position: refs/heads/master@{#36144}

Powered by Google App Engine
This is Rietveld 408576698