Plumb in flag for reusing scratch textures

include/gpu/GrContext.h

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef GrContext_DEFINED
@@ skipping 28 matching lines @@
 class GrVertexBufferAllocPool;
 class GrSoftwarePathRenderer;
 class SkStrokeRec;
 
 class GR_API GrContext : public GrRefCnt {
 public:
     SK_DECLARE_INST_COUNT(GrContext)
 
     /**
      * Creates a GrContext for a backend context.
      */

[robertphillips, 2013/07/17 16:51:32]

An option would be to pass in a tri-value enum (e.g., reuse, don't, default).

-    static GrContext* Create(GrBackend, GrBackendContext);
+    static GrContext* Create(GrBackend, GrBackendContext, bool* reuseScratchTextures = NULL);
 
     /**
      * Returns the number of GrContext instances for the current thread.
      */
     static int GetThreadInstanceCount();
 
     virtual ~GrContext();
 
     /**
      * The GrContext normally assumes that no outsider is setting state
@@ skipping 17 matching lines @@
      * The 'info' parameter will be stored and passed to the callback function.
      */
     void addCleanUp(PFCleanUpFunc cleanUp, void* info) {
         CleanUpData* entry = fCleanUpData.push();
 
         entry->fFunc = cleanUp;
         entry->fInfo = info;
     }
 
     /**
+     * Change the context's scratch texture reuse behavior. On some platforms
+     * reusing scratch textures can cause the driver to ghost the texture 
+     * which, in excess, can lead to out of memory problems
+     */

[robertphillips, 2013/07/17 16:51:32]

This would remain a bool

+    void setReuseScratchTextures(bool reuseScratchTextures) { 
+        fReuseScratchTextures = reuseScratchTextures; 
+    }
+
+    /**
      * Abandons all GPU resources, assumes 3D API state is unknown. Call this
      * if you have lost the associated GPU context, and thus internal texture,
      * buffer, etc. references/IDs are now invalid. Should be called even when
      * GrContext is no longer going to be used for two reasons:
      *  1) ~GrContext will not try to free the objects in the 3D API.
      *  2) If you've created GrResources that outlive the GrContext they will
      *     be marked as invalid (GrResource::isValid()) and won't attempt to
      *     free their underlying resource in the 3D API.
      * Content drawn since the last GrContext::flush() may be lost.
      */
@@ skipping 761 matching lines @@
     GrVertexBufferAllocPool*        fDrawBufferVBAllocPool;
     GrIndexBufferAllocPool*         fDrawBufferIBAllocPool;
     GrInOrderDrawBuffer*            fDrawBuffer;
 
     GrAARectRenderer*               fAARectRenderer;
     GrOvalRenderer*                 fOvalRenderer;
 
     bool                            fDidTestPMConversions;
     int                             fPMToUPMConversion;
     int                             fUPMToPMConversion;
 

[robertphillips, 2013/07/17 16:51:32]

This would remain a bool

+    bool                            fReuseScratchTextures;
+
     struct CleanUpData {
         PFCleanUpFunc fFunc;
         void*         fInfo;
     };
 
     SkTDArray<CleanUpData>      fCleanUpData;
 
     GrContext(); // init must be called after the constructor.

[robertphillips, 2013/07/17 16:51:32]

This would also become tri-value

-    bool init(GrBackend, GrBackendContext);
+    bool init(GrBackend, GrBackendContext, bool *reuseScratchTextures);
 
     void setupDrawBuffer();
 
     class AutoRestoreEffects;
     /// Sets the paint and returns the target to draw into. The paint can be NULL in which case the
     /// draw state is left unmodified.
     GrDrawTarget* prepareToDraw(const GrPaint*, BufferedDraw, AutoRestoreEffects*);
 
     void internalDrawPath(GrDrawTarget* target, bool useAA, const SkPath& path,
                           const SkStrokeRec& stroke);
@@ skipping 113 matching lines @@
     }
 
     GrTexture* texture() { return fTexture; }
 
 private:
     GrContext*                    fContext;
     GrTexture*                    fTexture;
 };
 
 #endif