Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 1963573002: Fix running precompiled tests on Android. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 8d189ae90a65ee3caa427eff850bf91870802d09..d862db53225d23ea4680784b1c2c107684951dee 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -2543,9 +2543,9 @@ class CommandExecutorImpl implements CommandExecutor {
// pushhing it for every single test (this is bad for SSD cycle time, test
// timing).
steps.add(() => device.runAdbCommand(
- ['push', runner, '$devicedir/runner']));
+ ['push', runner, '$devicedir/dart_precompiled_runtime']));
steps.add(() => device.runAdbShellCommand(
- ['chmod', '777', '$devicedir/runner']));
+ ['chmod', '777', '$devicedir/dart_precompiled_runtime']));
for (var file in files) {
steps.add(() => device.runAdbCommand(
@@ -2554,12 +2554,16 @@ class CommandExecutorImpl implements CommandExecutor {
if (command.useBlobs) {
steps.add(() => device.runAdbShellCommand(
- ['$devicedir/runner', '--run-precompiled-snapshot=$deviceTestDir',
- '--use_blobs', 'ignored.dart'], timeout: timeoutDuration));
+ ['$devicedir/dart_precompiled_runtime',
+ '--run-app-snapshot=$deviceTestDir',
+ '--use-blobs', 'ignored.dart'],
+ timeout: timeoutDuration));
} else {
steps.add(() => device.runAdbShellCommand(
- ['$devicedir/runner', '--run-precompiled-snapshot=$deviceTestDir',
- 'ignored.dart'], timeout: timeoutDuration));
+ ['$devicedir/dart_precompiled_runtime',
+ '--run-app-snapshot=$deviceTestDir',
+ 'ignored.dart'],
+ timeout: timeoutDuration));
}
var stopwatch = new Stopwatch()..start();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698