Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1963563003: Update translate related OWNERS (Closed)

Created:
4 years, 7 months ago by Takashi Toyoshima
Modified:
4 years, 7 months ago
CC:
arv+watch_chromium.org, sdefresne+watch_chromium.org, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update translate related OWNERS Add new owner, and change to have only one real OWNERS and others just refers it by file://components/translate/OWNERS. Committed: https://crrev.com/0d7d7de910c9c54b25458d439b81a029398a0e6e Cr-Commit-Position: refs/heads/master@{#392574}

Patch Set 1 #

Patch Set 2 : use file:// redirect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -39 lines) Patch
M chrome/browser/resources/translate_internals/OWNERS View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/translate/OWNERS View 1 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/OWNERS View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/translate/OWNERS View 1 1 chunk +1 line, -9 lines 0 comments Download
M chrome/test/data/translate/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download
M components/language_usage_metrics/OWNERS View 1 1 chunk +1 line, -4 lines 0 comments Download
M components/translate/OWNERS View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/translate/OWNERS View 1 1 chunk +1 line, -6 lines 0 comments Download
M third_party/cld/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/cld_2/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Takashi Toyoshima
Hi translate owners. I would like to add groby@ to translate related owners files who ...
4 years, 7 months ago (2016-05-09 10:56:09 UTC) #4
droger
lgtm I'm fine using "file://component/translate/OWNERS" too, I don't have a strong opinion.
4 years, 7 months ago (2016-05-09 11:46:38 UTC) #5
hajimehoshi
lgtm On 2016/05/09 10:56:09, Takashi Toyoshima (still slow) wrote: > Hi translate owners. > I ...
4 years, 7 months ago (2016-05-09 11:47:01 UTC) #6
MAD
lgtm
4 years, 7 months ago (2016-05-09 21:10:44 UTC) #7
Takashi Toyoshima
CL and description were updated to use file://components/translate/OWNERS now. CC groby just in case. I'd ...
4 years, 7 months ago (2016-05-10 06:04:37 UTC) #9
Andrew Hayden (chromium.org)
LGTM. Sorry, I've been out ill.
4 years, 7 months ago (2016-05-10 08:32:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1963563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1963563003/20001
4 years, 7 months ago (2016-05-10 08:35:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 10:35:07 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0d7d7de910c9c54b25458d439b81a029398a0e6e Cr-Commit-Position: refs/heads/master@{#392574}
4 years, 7 months ago (2016-05-10 10:36:42 UTC) #17
groby-ooo-7-16
4 years, 7 months ago (2016-05-10 14:38:58 UTC) #19
Message was sent while issue was closed.
Thank you for adding me.

Powered by Google App Engine
This is Rietveld 408576698