Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: ui/message_center/views/notifier_settings_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/notification_button.cc ('k') | ui/message_center/views/padded_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notifier_settings_view.cc
diff --git a/ui/message_center/views/notifier_settings_view.cc b/ui/message_center/views/notifier_settings_view.cc
index 978e3b96aded5458b86dca8e5edcbf21f0376b19..c8482d5bc763c4f1a0b85fdb3c88a7ed3d56e220 100644
--- a/ui/message_center/views/notifier_settings_view.cc
+++ b/ui/message_center/views/notifier_settings_view.cc
@@ -306,7 +306,6 @@ NotifierSettingsView::NotifierButton::NotifierButton(
// Create a more-info button that will be right-aligned.
learn_more_ = new views::ImageButton(this);
learn_more_->SetFocusPainter(CreateFocusPainter());
- learn_more_->set_request_focus_on_press(false);
views::Button::ConfigureDefaultFocus(learn_more_);
ui::ResourceBundle& rb = ResourceBundle::GetSharedInstance();
@@ -584,6 +583,7 @@ void NotifierSettingsView::UpdateContentsView(
notifier_group_selector_->SetFocusPainter(nullptr);
notifier_group_selector_->set_animate_on_state_change(false);
views::Button::ConfigureDefaultFocus(notifier_group_selector_);
+ notifier_group_selector_->set_request_focus_on_press(true);
contents_title_view->AddChildView(notifier_group_selector_);
}
« no previous file with comments | « ui/message_center/views/notification_button.cc ('k') | ui/message_center/views/padded_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698