Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index 97e513e2fed13ae28dd57106874dc984aa270d03..8b006f04a2b8d2fa52dcd7a141d1134609259cef 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -73,12 +73,9 @@ ToolbarActionView::ToolbarActionView(
set_context_menu_controller(this);
// If the button is within a menu, we need to make it focusable in order to
- // have it accessible via keyboard navigation, but it shouldn't request focus
- // (because that would close the menu).
- if (delegate_->ShownInsideMenu()) {
- set_request_focus_on_press(false);
+ // have it accessible via keyboard navigation.
+ if (delegate_->ShownInsideMenu())
SetFocusBehavior(FocusBehavior::ALWAYS);
- }
UpdateState();
}
« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu.cc ('k') | chrome/browser/ui/views/website_settings/chosen_object_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698