chrome/browser/ui/views/profiles/profile_chooser_view.cc - Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.cc ('k') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

index 9ab06368fb293e2159c60b1dc7dcab1d211ca0ea..e00db230f41f5a470983131aa694c086c5f52011 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc

@@ -157,6 +157,7 @@ views::ImageButton* CreateBackButton(views::ButtonListener* listener) {

back_button->SetImage(views::ImageButton::STATE_DISABLED,

rb->GetImageSkiaNamed(IDR_BACK_D));

views::Button::ConfigureDefaultFocus(back_button);

+ back_button->set_request_focus_on_press(true);

return back_button;

}

@@ -176,6 +177,7 @@ class BackgroundColorHoverButton : public views::LabelButton {

kButtonHeight + views::kRelatedControlVerticalSpacing));

SetImage(STATE_NORMAL, icon);

Button::ConfigureDefaultFocus(this);

+ set_request_focus_on_press(true);

}

~BackgroundColorHoverButton() override {}

@@ -1404,6 +1406,7 @@ views::View* ProfileChooserView::CreateCurrentProfileView(

gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,

gfx::kChromeIconGrey));

views::Button::ConfigureDefaultFocus(auth_error_email_button_);

+ auth_error_email_button_->set_request_focus_on_press(true);

gfx::Insets insets =

views::LabelButtonAssetBorder::GetDefaultInsetsForStyle(

views::Button::STYLE_TEXTBUTTON);