Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7857)

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/find_bar_view.cc
diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc
index c41d3dee1f166b5ef60d9743379be76f796ba5b5..7e76a4c17354f0bd9bed5208ee3c56fbce4442d1 100644
--- a/chrome/browser/ui/views/find_bar_view.cc
+++ b/chrome/browser/ui/views/find_bar_view.cc
@@ -155,7 +155,6 @@ FindBarView::FindBarView(FindBarHost* host)
find_previous_button_->set_id(VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);
views::Button::ConfigureDefaultFocus(find_previous_button_);
- find_previous_button_->set_request_focus_on_press(false);
find_previous_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));
find_previous_button_->SetAccessibleName(
@@ -164,7 +163,6 @@ FindBarView::FindBarView(FindBarHost* host)
find_next_button_->set_id(VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);
views::Button::ConfigureDefaultFocus(find_next_button_);
- find_next_button_->set_request_focus_on_press(false);
find_next_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));
find_next_button_->SetAccessibleName(
@@ -173,7 +171,6 @@ FindBarView::FindBarView(FindBarHost* host)
close_button_->set_id(VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON);
views::Button::ConfigureDefaultFocus(close_button_);
- close_button_->set_request_focus_on_press(false);
close_button_->SetTooltipText(
l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));
close_button_->SetAccessibleName(

Powered by Google App Engine
This is Rietveld 408576698