chrome/browser/ui/views/find_bar_view.cc - Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/find_bar_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc ('k') | chrome/browser/ui/views/infobars/infobar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/find_bar_view.cc

diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc

index c41d3dee1f166b5ef60d9743379be76f796ba5b5..7e76a4c17354f0bd9bed5208ee3c56fbce4442d1 100644

--- a/chrome/browser/ui/views/find_bar_view.cc

+++ b/chrome/browser/ui/views/find_bar_view.cc

@@ -155,7 +155,6 @@ FindBarView::FindBarView(FindBarHost* host)

find_previous_button_->set_id(VIEW_ID_FIND_IN_PAGE_PREVIOUS_BUTTON);

views::Button::ConfigureDefaultFocus(find_previous_button_);

- find_previous_button_->set_request_focus_on_press(false);

find_previous_button_->SetTooltipText(

l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_PREVIOUS_TOOLTIP));

find_previous_button_->SetAccessibleName(

@@ -164,7 +163,6 @@ FindBarView::FindBarView(FindBarHost* host)

find_next_button_->set_id(VIEW_ID_FIND_IN_PAGE_NEXT_BUTTON);

views::Button::ConfigureDefaultFocus(find_next_button_);

- find_next_button_->set_request_focus_on_press(false);

find_next_button_->SetTooltipText(

l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_NEXT_TOOLTIP));

find_next_button_->SetAccessibleName(

@@ -173,7 +171,6 @@ FindBarView::FindBarView(FindBarHost* host)

close_button_->set_id(VIEW_ID_FIND_IN_PAGE_CLOSE_BUTTON);

views::Button::ConfigureDefaultFocus(close_button_);

- close_button_->set_request_focus_on_press(false);

close_button_->SetTooltipText(

l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP));

close_button_->SetAccessibleName(