Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8015)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.cc

Issue 1963563002: Views: Flip default value of CustomButton::request_focus_on_press_ to false. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo unrelated changes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index ba23c02554232f27906667e8e486c22b56d40fc0..6be23b355a8754ea79b8586c1fde95e1242b79b1 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -155,6 +155,7 @@ views::ImageButton* CreateBackButton(views::ButtonListener* listener) {
back_button->SetImage(views::ImageButton::STATE_DISABLED,
rb->GetImageSkiaNamed(IDR_BACK_D));
views::Button::ConfigureDefaultFocus(back_button);
+ back_button->set_request_focus_on_press(true);
return back_button;
}
@@ -174,6 +175,7 @@ class BackgroundColorHoverButton : public views::LabelButton {
kButtonHeight + views::kRelatedControlVerticalSpacing));
SetImage(STATE_NORMAL, icon);
Button::ConfigureDefaultFocus(this);
+ set_request_focus_on_press(true);
}
~BackgroundColorHoverButton() override {}
@@ -1399,6 +1401,7 @@ views::View* ProfileChooserView::CreateCurrentProfileView(
gfx::CreateVectorIcon(gfx::VectorIconId::WARNING, 18,
gfx::kChromeIconGrey));
views::Button::ConfigureDefaultFocus(auth_error_email_button_);
+ auth_error_email_button_->set_request_focus_on_press(true);
gfx::Insets insets =
views::LabelButtonAssetBorder::GetDefaultInsetsForStyle(
views::Button::STYLE_TEXTBUTTON);

Powered by Google App Engine
This is Rietveld 408576698