Views: Flip default value of CustomButton::request_focus_on_press_ to false.

chrome/browser/ui/views/toolbar/toolbar_action_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/toolbar_action_view.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 55 matching lines @@
   set_ink_drop_delegate(ink_drop_delegate_.get());
   set_has_ink_drop_action_on_click(true);
   set_id(VIEW_ID_BROWSER_ACTION);
   view_controller_->SetDelegate(this);
   SetHorizontalAlignment(gfx::ALIGN_CENTER);
   set_drag_controller(delegate_);
 
   set_context_menu_controller(this);
 
   // If the button is within a menu, we need to make it focusable in order to
-  // have it accessible via keyboard navigation, but it shouldn't request focus
-  // (because that would close the menu).
-  if (delegate_->ShownInsideMenu()) {
-    set_request_focus_on_press(false);
+  // have it accessible via keyboard navigation.
+  if (delegate_->ShownInsideMenu())
     SetFocusBehavior(FocusBehavior::ALWAYS);
-  }
 
   UpdateState();
 }
 
 ToolbarActionView::~ToolbarActionView() {
   // Avoid access to a destroyed InkDropDelegate when the |pressed_lock_| is
   // destroyed.
   set_ink_drop_delegate(nullptr);
   view_controller_->SetDelegate(nullptr);
 }
@@ skipping 234 matching lines @@
     if (menu_controller->in_nested_run()) {
       // There is another menu showing. Close the outermost menu (since we are
       // shown in the same menu, we don't want to close the whole thing).
       menu_controller->Cancel(views::MenuController::EXIT_OUTERMOST);
       return true;
     }
   }
 
   return false;
 }