Views: Flip default value of CustomButton::request_focus_on_press_ to false.

ash/shell/lock_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/session/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell/example_factory.h"
 #include "ash/shell_window_ids.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/aura/window.h"
@@ skipping 12 matching lines @@
 namespace ash {
 namespace shell {
 
 class LockView : public views::WidgetDelegateView,
                  public views::ButtonListener {
  public:
   LockView() : unlock_button_(new views::LabelButton(
                                   this, base::ASCIIToUTF16("Unlock"))) {
     unlock_button_->SetStyle(views::Button::STYLE_BUTTON);
     AddChildView(unlock_button_);
     views::Button::ConfigureDefaultFocus(unlock_button_);

[oshima, 2016/05/11 14:58:27]

It wasn't obvious to me that this will enable focus on button.
Consider name like

Button::SetPlatformFocusable(unlock_button_);
Button::EnablePlatformFocus(unlock_button_);

[karandeepb, 2016/05/12 00:45:28]

Will rename this in a subsequent CL. Thanks.

+    unlock_button_->set_request_focus_on_press(true);
   }
   ~LockView() override {}
 
   // Overridden from views::View:
   gfx::Size GetPreferredSize() const override { return gfx::Size(500, 400); }
 
  private:
   // Overridden from views::View:
   void OnPaint(gfx::Canvas* canvas) override {
     canvas->FillRect(GetLocalBounds(), SK_ColorYELLOW);
@@ skipping 55 matching lines @@
   widget->GetNativeView()->SetName("LockView");
   widget->GetNativeView()->Focus();
 
   // TODO: it shouldn't be necessary to invoke UpdateTooltip() here.
   Shell::GetInstance()->tooltip_controller()->UpdateTooltip(
       widget->GetNativeView());
 }
 
 }  // namespace shell
 }  // namespace ash