Issue 196353021: Revert "Implement support for expanding crop rects in image filters"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196353021: Revert "Implement support for expanding crop rects in image filters" (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert "Implement support for expanding crop rects in image filters" Breaking ImageFilterTests unit test. TBR=bsalomon@google.com BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13806

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -305 lines)			Patch
D	gm/imagefilterscropexpand.cpp	View	1 chunk	+0 lines, -170 lines	0 comments	Download
M	gm/imagefiltersgraph.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkImageFilter.h	View	1 chunk	+4 lines, -19 lines	0 comments	Download
M	src/core/SkImageFilter.cpp	View	3 chunks	+11 lines, -52 lines	0 comments	Download
M	src/effects/SkBlurImageFilter.cpp	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	src/effects/SkColorFilterImageFilter.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/effects/SkDisplacementMapEffect.cpp	View	5 chunks	+30 lines, -30 lines	0 comments	Download
M	src/effects/SkDropShadowImageFilter.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/effects/SkLightingImageFilter.cpp	View	2 chunks	+14 lines, -11 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/effects/SkMergeImageFilter.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/effects/SkOffsetImageFilter.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/effects/SkRectShaderImageFilter.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkXfermodeImageFilter.cpp	View	1 chunk	+6 lines, -5 lines	0 comments	Download

Total messages: 1 (0 generated)

Stephen White

6 years, 9 months ago (2014-03-14 16:48:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r13806 (presubmit successful).